[Spec] Updated the spec of the Genesis module #5752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movekevin
approved these changes
Dec 2, 2022
| @@ -426,17 +433,17 @@ module aptos_framework::genesis { | |||
| rewards_rate_denominator, | |||
| voting_power_increase_limit | |||
| ); | |||
|
|
|||
| features::change_feature_flags(aptos_framework, vector[1, 2], vector[]); | |||
There was a problem hiding this comment.
It's for initialize_features: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/vm-genesis/src/lib.rs#L393
rahxephon89
approved these changes
Dec 2, 2022
This commits update the `verify_only` genesis steps to reflect the `encode_aptos_mainnet_genesis_transaction` of `vm-genesis`. The spec of `create_signer` is added. One TODO is removed because the `Table` issue has been fixed.
junkil-park
force-pushed
the
jpark/spec-genesis
branch
from
1120602 to
a68d6a5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Closed
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
This commits update the `verify_only` genesis steps to reflect the `encode_aptos_mainnet_genesis_transaction` of `vm-genesis`. The spec of `create_signer` is added. One TODO is removed because the `Table` issue has been fixed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commits update the
[verify_only]function in genesis (i.e.,initialize_for_verification) to reflect theencode_aptos_mainnet_genesis_transactionofvm-genesis.The spec of
create_signeris added.One TODO is removed because the
Tableissue has been fixed.Test Plan
move prove