Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further clarify the messaging with mergify #5724

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

banool
Copy link
Contributor

@banool banool commented Nov 29, 2022

Description

Ideally this makes it even clearer, since as it is now, it isn't crystal clear enough to me. A red x is a strong signal that needs a strong message to defeat 😛

Test Plan

Unfortunately it doesn't seem like the PR to make the mergify change includes the change as part of the CI run. I could use the playground, but we can probs just go for it now.

@banool banool marked this pull request as ready for review November 29, 2022 15:05
@banool banool requested a review from a team as a code owner November 29, 2022 15:05
@banool banool enabled auto-merge (squash) November 29, 2022 16:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7186 TPS, 5321 ms latency, 8200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1
compatibility::simple-validator-upgrade::single-validator-upgrade : 4896 TPS, 8040 ms latency, 11100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1
compatibility::simple-validator-upgrade::half-validator-upgrade : 4944 TPS, 8167 ms latency, 11300 ms p99 latency,no expired txns
4. upgrading second batch to new version: dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7014 TPS, 5525 ms latency, 10200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on dbe3f0cd74a232871d37c59b14a19eecc5e8dcd1

performance benchmark with full nodes : 6466 TPS, 6130 ms latency, 11100 ms p99 latency,(!) expired 340 out of 2761700 txns
Test Ok

@banool banool merged commit 446a205 into main Nov 29, 2022
@banool banool deleted the banool/mergify_clarify_further branch November 29, 2022 17:27
@Markuze Markuze mentioned this pull request Dec 5, 2022
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants