-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS SDK] Update CoinClient to address #5648 and #5720 #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/coin_client_improvements
branch
2 times, most recently
from
November 29, 2022 14:56
06b2248
to
da1ca3e
Compare
banool
changed the title
[TS SDK] Add getBalance and trasnferCoin functions that address #5648 and #5720
[TS SDK] Update CoinClient to address #5648 and #5720
Nov 29, 2022
banool
force-pushed
the
banool/coin_client_improvements
branch
from
November 29, 2022 16:18
da1ca3e
to
075b5bd
Compare
jjleng
approved these changes
Nov 29, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
movekevin
approved these changes
Nov 29, 2022
Closed
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #5648 and #5720. While I'm here I fix some incorrect documentation on
checkBalance
, clarify the docs for generating ABIs, and add some more comments to these functions.Based on a manual inspection and the current / new tests, this should be backwards compatible.
Test Plan
I added new tests, run them like this: