-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aptos-stdlib] fix comparator tests #5694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! This looks like a bug in the comparator that needs to be fixed, rather than just updating the test. But your intention here is to show proof that this is happening.
I don't think this is bug. It ok too compare bcs serialized bytes. But the order of integer bcs serialized bytes will not be keep as the origin ones. There is no need to add a new compare method for integer only, so maybe we can just rename the method to make it more clear? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
we'll need to run this |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
* fix comparator tests * fix
Description
The comarator is not suitable for Move integer types. Add more comment to describe this and fix the unittest.
Test Plan
No