Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha] deprecate set-output for determinator #5682

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Nov 22, 2022

Description

::save-state and ::set-output GHA commands will be deprecated soon, as per: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and the warnings on runs such as: https://github.com/aptos-labs/aptos-core/actions/runs/3526688470

image

The warnings are visually noisy and you have to scroll past all of them to view test summaries.

This is mostly used in python test code and whatever sits behind our mini python target determinator determinator. There are some 3rd party Github Actions that still use it as well. For these we can either update the git ref for these if it's been updated upstream already, otherwise just leave it as is.

Test Plan

Determinator still works

@rustielin rustielin force-pushed the rustielin/deprecate-set-output branch 3 times, most recently from a1a9ea2 to a1f9d3d Compare November 22, 2022 21:57
@rustielin rustielin marked this pull request as ready for review November 23, 2022 00:49
@rustielin rustielin requested a review from a team as a code owner November 23, 2022 00:49
@rustielin rustielin force-pushed the rustielin/deprecate-set-output branch from a1f9d3d to b7fe6c1 Compare December 7, 2022 17:43
@rustielin rustielin enabled auto-merge (squash) December 7, 2022 17:43
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

✅ Forge suite land_blocking success on b7fe6c1c9076570313a6830b614c456b5b8957d5

performance benchmark with full nodes : 6638 TPS, 5978 ms latency, 7800 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7fe6c1c9076570313a6830b614c456b5b8957d5

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7fe6c1c9076570313a6830b614c456b5b8957d5 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7739 TPS, 5196 ms latency, 7700 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b7fe6c1c9076570313a6830b614c456b5b8957d5
compatibility::simple-validator-upgrade::single-validator-upgrade : 5180 TPS, 7964 ms latency, 10300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b7fe6c1c9076570313a6830b614c456b5b8957d5
compatibility::simple-validator-upgrade::half-validator-upgrade : 4547 TPS, 9122 ms latency, 11700 ms p99 latency,no expired txns
4. upgrading second batch to new version: b7fe6c1c9076570313a6830b614c456b5b8957d5
compatibility::simple-validator-upgrade::rest-validator-upgrade : 5270 TPS, 7428 ms latency, 16700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7fe6c1c9076570313a6830b614c456b5b8957d5 passed
Test Ok

@rustielin rustielin disabled auto-merge December 7, 2022 18:37
@rustielin rustielin merged commit dcfbe73 into main Dec 7, 2022
@rustielin rustielin deleted the rustielin/deprecate-set-output branch December 7, 2022 18:37
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants