Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] lint fmt check #5537

Merged
merged 4 commits into from
Nov 15, 2022
Merged

[python] lint fmt check #5537

merged 4 commits into from
Nov 15, 2022

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Nov 11, 2022 •
edited
Loading

Description

Some better testing for python code. Now includes pyright for static type checking (to use alongside devs' setup with pylance), and black for formatting

Ignore type checking in some areas for the reasons of:

  • ForgeConfig class having optional fields for backwards compatibility reasons
  • For some unit tests which check for assertions being non-null and having error msgs

Test Plan

Fix locally, and make sure CI passes now
https://github.com/aptos-labs/aptos-core/actions/runs/3441551789/jobs/5741220501

This change is Reviewable

@rustielin rustielin requested a review from a team as a code owner November 11, 2022 00:34
@rustielin rustielin force-pushed the rustielin/python-lint-fmt branch 2 times, most recently from 12c0515 to d1ca9c2 Compare November 11, 2022 00:38
@rustielin rustielin force-pushed the rustielin/python-lint-fmt branch from d1ca9c2 to a9eec26 Compare November 15, 2022 20:02
@rustielin rustielin enabled auto-merge (squash) November 15, 2022 20:02
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7400 TPS, 5234 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0
compatibility::simple-validator-upgrade::single-validator-upgrade : 4427 TPS, 9283 ms latency, 13300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0
compatibility::simple-validator-upgrade::half-validator-upgrade : 4735 TPS, 8572 ms latency, 10500 ms p99 latency,no expired txns
4. upgrading second batch to new version: a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7006 TPS, 5600 ms latency, 12100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on a9eec26e44cd6b4edb0fc1efa98ecddddb3f32b0

performance benchmark with full nodes : 6849 TPS, 5800 ms latency, 9000 ms p99 latency,no expired txns
Test Ok

@rustielin rustielin merged commit 20f32b8 into main Nov 15, 2022
@rustielin rustielin deleted the rustielin/python-lint-fmt branch November 15, 2022 20:31
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@rustielin @areshand
[python] lint fmt check (aptos-labs#5537)
3056121 
* [gha] python lint fmt

* [python] run black

* [gha] run pyright for python static type checking

* [python] fix lint and fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perryjrandall perryjrandall perryjrandall approved these changes

@davidiw davidiw davidiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustielin @davidiw @perryjrandall