Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] remove unnecessary lines creating resource acct signer #5486

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

lightmark
Copy link
Contributor

@lightmark lightmark commented Nov 7, 2022

Description

Read to learn. And I think it is not useful and a waste of gas. Remove it.

Test Plan

ut


This change is Reviewable

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay, but why the commenting out of code?

@lightmark lightmark enabled auto-merge (squash) November 7, 2022 23:35
@lightmark lightmark disabled auto-merge November 17, 2022 07:19
@lightmark lightmark enabled auto-merge (squash) November 17, 2022 07:19
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 933cf213eeff44fcbb3f8909147c7591a907b8c3

performance benchmark with full nodes : 6938 TPS, 5716 ms latency, 9300 ms p99 latency,(!) expired 100 out of 2962700 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 933cf213eeff44fcbb3f8909147c7591a907b8c3

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 933cf213eeff44fcbb3f8909147c7591a907b8c3 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7120 TPS, 5389 ms latency, 8300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 933cf213eeff44fcbb3f8909147c7591a907b8c3
compatibility::simple-validator-upgrade::single-validator-upgrade : 4854 TPS, 8341 ms latency, 11300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 933cf213eeff44fcbb3f8909147c7591a907b8c3
compatibility::simple-validator-upgrade::half-validator-upgrade : 4874 TPS, 8530 ms latency, 10900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 933cf213eeff44fcbb3f8909147c7591a907b8c3
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7035 TPS, 5620 ms latency, 10100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 933cf213eeff44fcbb3f8909147c7591a907b8c3 passed
Test Ok

@lightmark lightmark merged commit cf6bb40 into main Nov 29, 2022
@lightmark lightmark deleted the fix_signer branch November 29, 2022 13:37
@Markuze Markuze mentioned this pull request Dec 5, 2022
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants