Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[token] token::get_direct_transfer public fun #5470

Merged
merged 7 commits into from
Dec 11, 2022
Merged

[token] token::get_direct_transfer public fun #5470

merged 7 commits into from
Dec 11, 2022

Conversation

bduman
Copy link
Contributor

@bduman bduman commented Nov 6, 2022 •
edited by geekflyer
Loading

for the purpose of reverting case after using token::opt_in_direct_transfer

Description

Test Plan

This change is Reviewable

@bduman
token::get_direct_transfer public fun
43338a3 
for the purpose of reverting case after using token::opt_in_direct_transfer
@bduman bduman requested a review from areshand as a code owner November 6, 2022 19:44
davidiw
davidiw approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, probably should be down near line 1100 near other getters though. @areshand -- pushing to you.

@davidiw davidiw enabled auto-merge (squash) December 3, 2022 22:07
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@davidiw davidiw disabled auto-merge December 11, 2022 03:11
@davidiw davidiw enabled auto-merge (squash) December 11, 2022 03:12
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@davidiw
Copy link
Contributor

davidiw commented Dec 11, 2022

we'll need to update this with cargo build -p aptos-cached-packages

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

❌ Forge suite land_blocking failure on eace14ba04e0b7050aff31596442644233847f20

performance benchmark with full nodes : 5969 TPS, 6650 ms latency, 11400 ms p99 latency,(!) expired 840 out of 2550020 txns
Test Failed: check for success

Caused by:
    TPS requirement failed. Average TPS 5969, minimum TPS requirement 6000
Trailing Log Lines:

Caused by:
    TPS requirement failed. Average TPS 5969, minimum TPS requirement 6000
Test Statistics: 
performance benchmark with full nodes : 5969 TPS, 6650 ms latency, 11400 ms p99 latency,(!) expired 840 out of 2550020 txns
Test Failed: check for success

Caused by:
    TPS requirement failed. Average TPS 5969, minimum TPS requirement 6000


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:280"},"thread_name":"main","hostname":"forge-e2e-pr-5470-1670781336-eace14ba04e0b7050aff31596442644233","timestamp":"2022-12-11T18:13:11.315453Z","message":"Deleting namespace forge-e2e-pr-5470: Some(NamespaceStatus { phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:388"},"thread_name":"main","hostname":"forge-e2e-pr-5470-1670781336-eace14ba04e0b7050aff31596442644233","timestamp":"2022-12-11T18:13:11.315531Z","message":"aptos-node resources for Forge removed in namespace: forge-e2e-pr-5470"}

failures:
    performance benchmark with full nodes

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-0-validator-0                1/1     Running     0          13m
aptos-node-1-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-1-validator-0                1/1     Running     0          13m
aptos-node-10-validator-0               1/1     Running     0          13m
aptos-node-11-validator-0               1/1     Running     0          13m
aptos-node-12-validator-0               1/1     Running     0          13m
aptos-node-13-validator-0               1/1     Running     0          13m
aptos-node-14-validator-0               1/1     Running     0          13m
aptos-node-15-validator-0               1/1     Running     0          13m
aptos-node-16-validator-0               1/1     Running     0          13m
aptos-node-17-validator-0               1/1     Running     0          13m
aptos-node-18-validator-0               1/1     Running     0          13m
aptos-node-19-validator-0               1/1     Running     0          13m
aptos-node-2-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-2-validator-0                1/1     Running     0          13m
aptos-node-3-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-3-validator-0                1/1     Running     0          13m
aptos-node-4-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-4-validator-0                1/1     Running     0          13m
aptos-node-5-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-5-validator-0                1/1     Running     0          13m
aptos-node-6-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-6-validator-0                1/1     Running     0          13m
aptos-node-7-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-7-validator-0                1/1     Running     0          13m
aptos-node-8-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-8-validator-0                1/1     Running     0          13m
aptos-node-9-fullnode-eforge131-0       1/1     Running     0          13m
aptos-node-9-validator-0                1/1     Running     0          13m
genesis-aptos-genesis-eforge131-9ndlw   0/1     Completed   0          16m

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> eace14ba04e0b7050aff31596442644233847f20

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> eace14ba04e0b7050aff31596442644233847f20 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7464 TPS, 5179 ms latency, 7600 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: eace14ba04e0b7050aff31596442644233847f20
compatibility::simple-validator-upgrade::single-validator-upgrade : 4306 TPS, 9479 ms latency, 12500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: eace14ba04e0b7050aff31596442644233847f20
compatibility::simple-validator-upgrade::half-validator-upgrade : 4580 TPS, 8696 ms latency, 11500 ms p99 latency,no expired txns
4. upgrading second batch to new version: eace14ba04e0b7050aff31596442644233847f20
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6058 TPS, 6404 ms latency, 11100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> eace14ba04e0b7050aff31596442644233847f20 passed
Test Ok

@davidiw davidiw disabled auto-merge December 11, 2022 18:26
@davidiw davidiw merged commit b901a4b into aptos-labs:main Dec 11, 2022
areshand added a commit to areshand/aptos-core-1 that referenced this pull request Dec 16, 2022
@bduman @areshand @davidiw
[token] token::get_direct_transfer public fun (aptos-labs#5470)
7ef11c9 
* token::get_direct_transfer public fun

for the purpose of reverting case after using token::opt_in_direct_transfer

* default result for get_direct_transfer

* token::get_direct_transfer is moved

* f

Co-authored-by: Bo Wu <[email protected]>
Co-authored-by: David Wolinsky <[email protected]>
areshand added a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@bduman @areshand @davidiw
[token] token::get_direct_transfer public fun (aptos-labs#5470)
cc6e544 
* token::get_direct_transfer public fun

for the purpose of reverting case after using token::opt_in_direct_transfer

* default result for get_direct_transfer

* token::get_direct_transfer is moved

* f

Co-authored-by: Bo Wu <[email protected]>
Co-authored-by: David Wolinsky <[email protected]>
movekevin pushed a commit that referenced this pull request Dec 19, 2022
@bduman @areshand
@davidiw @movekevin
[token] token::get_direct_transfer public fun (#5470)
a748f42 
* token::get_direct_transfer public fun

for the purpose of reverting case after using token::opt_in_direct_transfer

* default result for get_direct_transfer

* token::get_direct_transfer is moved

* f

Co-authored-by: Bo Wu <[email protected]>
Co-authored-by: David Wolinsky <[email protected]>
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areshand areshand areshand approved these changes

@davidiw davidiw davidiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bduman @davidiw @areshand