-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Developer Tutorials】fix useEffect() #4988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariria
reviewed
Dec 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for bringing this to our attention, great suggestion. I added a suggestion on how we could improve on it. Lmk what you think
add connect() function before account() function.
Co-authored-by: Andrew Hariri <[email protected]>
hariria
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
* fix useEffect() add connect() function before account() function. * Update developer-docs-site/docs/tutorials/first-dapp.md Co-authored-by: Andrew Hariri <[email protected]> Co-authored-by: David Wolinsky <[email protected]> Co-authored-by: Andrew Hariri <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add connect() function.
Description
add connect() function before account() function.
Test Plan
I tried aptos's tutorial 「Your First Dapp」and
window.aptos.account()
in the app didn't work well.So I added
connect()
function beforeaccount()
function.Below is the link of my github repo.
https://github.com/mashharuki/AptosRepo
Pleae try the following to test.
cd first-dapp
npm i
npm run start
You can see a dapp like this.
![スクリーンショット 2022-10-12 16 46 07](https://user-images.githubusercontent.com/44923695/195281889-0d952117-ed60-4f2e-a787-2acf79917b6f.png)
If you push "送信" button , a popup will appear.
![スクリーンショット 2022-10-12 16 47 23](https://user-images.githubusercontent.com/44923695/195282148-c8efaa2f-3069-4fa7-b640-95f33a1fe2b9.png)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)