Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Developer Tutorials】fix useEffect() #4988

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Conversation

mashharuki
Copy link
Contributor

@mashharuki mashharuki commented Oct 12, 2022

add connect() function.

Description

add connect() function before account() function.

Test Plan

I tried aptos's tutorial 「Your First Dapp」and window.aptos.account() in the app didn't work well.
So I added connect() function before account() function.

Below is the link of my github repo.

https://github.com/mashharuki/AptosRepo

Pleae try the following to test.

  1. cd first-dapp
  2. npm i
  3. npm run start
  4. please access to http://localhost:3000

You can see a dapp like this.
スクリーンショット 2022-10-12 16 46 07

If you push "送信" button , a popup will appear.
スクリーンショット 2022-10-12 16 47 23


This change is Reviewable

@mashharuki mashharuki requested a review from areshand as a code owner October 12, 2022 07:48
@mashharuki mashharuki changed the title fix useEffect() 【Developer Tutorials】fix useEffect() Oct 12, 2022
Copy link
Contributor

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for bringing this to our attention, great suggestion. I added a suggestion on how we could improve on it. Lmk what you think

developer-docs-site/docs/tutorials/first-dapp.md Outdated Show resolved Hide resolved
mashharuki and others added 2 commits December 3, 2022 15:22
add connect() function before account() function.
Copy link
Contributor

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidiw davidiw merged commit 537d171 into aptos-labs:main Dec 3, 2022
@mashharuki
Copy link
Contributor Author

@hariria @davidiw Thank you very much!!

@Markuze Markuze mentioned this pull request Dec 5, 2022
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
* fix useEffect()

add connect() function before account() function.

* Update developer-docs-site/docs/tutorials/first-dapp.md

Co-authored-by: Andrew Hariri <[email protected]>

Co-authored-by: David Wolinsky <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants