-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests only][aptos_framework] chain_id: initialize for test (to specify any chain_id) #4406
Merged
davidiw
merged 11 commits into
aptos-labs:main
from
linnefromice:update-chain_id-for-test
Sep 26, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6f669e5
update: chain_id - add func to update chain_id for test
linnefromice 79775f4
Merge branch 'main' into update-chain_id-for-test
linnefromice ad31f99
Merge branch 'main' into update-chain_id-for-test
linnefromice c4a0d2e
Merge branch 'main' into update-chain_id-for-test
linnefromice 2560a3e
update: chain_id - add initialize_for_test instead of change_id
linnefromice 8205cf9
Merge branch 'main' into update-chain_id-for-test
linnefromice 5505a6f
Merge branch 'main' into update-chain_id-for-test
linnefromice 5e857fd
Merge branch 'main' into update-chain_id-for-test
linnefromice 90088ed
Merge branch 'main' into update-chain_id-for-test
linnefromice 0df1fca
Merge branch 'main' into update-chain_id-for-test
linnefromice 39fd198
Merge branch 'main' into update-chain_id-for-test
linnefromice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you ever need to change the chain id in move unit tests? May be you're looking for initialize_for_test so you can initialize the chain id once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have to be able to change it, but I would like to specify.
I agree with you, "initialize_for_test" is enough. I fixed. 2560a3e
At first I thought of this flow.