Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the txn waiting bug #3540

Merged
merged 1 commit into from
Aug 27, 2022
Merged

fix: fix the txn waiting bug #3540

merged 1 commit into from
Aug 27, 2022

Conversation

jjleng
Copy link
Contributor

@jjleng jjleng commented Aug 26, 2022

Description

Test Plan


This change is Reviewable

@gregnazario gregnazario requested a review from kent-white August 26, 2022 22:24
@kent-white
Copy link
Contributor

Do we want to do this for the waitForTransaction function as well?

@kent-white
Copy link
Contributor

Never mind, it will fix for both

@gregnazario gregnazario merged commit 8399cd1 into devnet Aug 27, 2022
@gregnazario gregnazario deleted the ts-sdk-1.3.10 branch August 27, 2022 02:47
Copy link

@InvestorJoe InvestorJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved

@InvestorJoe
Copy link

Test Plan

Copy link

@InvestorJoe InvestorJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

a discussion (no related file):
Test Plan


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants