Add TS component of the First NFT with SDK tutorial #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/ts_first_nft
branch
from
649df61 to
8f8a7af
Compare
banool
changed the base branch from
main
to
banool/rust_sdk_first_transaction_dev_doxs
areshand
reviewed
Aug 25, 2022
| * Official Aptos Rust SDK -- TBA | ||
|
|
||
| ## Step 2: Run the Example | ||
|
|
||
| Each SDK provides an examples directory. This tutorial covers the `simple-nft` example. | ||
|
|
||
| <Tabs> | ||
| Clone `aptos-core`: |
There was a problem hiding this comment.
just curious why we add a new doc instead of revising existing first_nft doc using the SDK? eventually, I expect we will only have one first_nft.
There was a problem hiding this comment.
@davidiw could probably speak more about the decision to write a new tutorial. I can see that the new tutorial is heavily inspired by the old one, but I think the intent is to focus less on theory and internals. I suppose it was easier to write a new tutorial afresh in this case.
Base automatically changed from
banool/rust_sdk_first_transaction_dev_doxs
to
main
August 25, 2022 07:40
banool
force-pushed
the
banool/ts_first_nft
branch
3 times, most recently
from
ec66762 to
a345cc7
Compare
banool
changed the title
banool
requested review from
davidiw,
gregnazario,
jjleng and
rajkaramchedu
as code owners
banool
force-pushed
the
banool/ts_first_nft
branch
from
a345cc7 to
ce75bb5
Compare
areshand
approved these changes
Aug 25, 2022
jjleng
reviewed
Aug 25, 2022
| @@ -321,7 +397,7 @@ export class TokenClient { | |||
| */ | |||
| async getTokenForAccount(account: MaybeHexString, tokenId: TokenTypes.TokenId): Promise<TokenTypes.Token> { | |||
| const tokenStore: { type: Gen.MoveStructTag; data: any } = await this.aptosClient.getAccountResource( | |||
| account, | |||
| account instanceof HexString ? account.hex() : account, | |||
There was a problem hiding this comment.
why is this? aptosClient handles this already by ensuring hex string is used.
There was a problem hiding this comment.
Well without this it was failing if I used account instead of account.hex() when calling this function. Or perhaps it was the other one for which that was true, in which case this is just for uniformity. I'll investigate AptosClient.
There was a problem hiding this comment.
interesting. please investigate.
| "multisig_transaction": "ts-node multisig_transaction.ts", | ||
| "transfer_coin": "ts-node transfer_coin.ts", | ||
| "simple_nft": "ts-node simple_nft.ts", | ||
| "test": "run-s transfer_coin bcs_transaction multisig_transaction" |
banool
force-pushed
the
banool/coin_client_uniformity
branch
3 times, most recently
from
4853f8a to
859065e
Compare
banool
force-pushed
the
banool/ts_first_nft
branch
from
ce75bb5 to
be81838
Compare
banool
force-pushed
the
banool/coin_client_uniformity
branch
from
859065e to
fbfd761
Compare
jjleng
approved these changes
Aug 25, 2022
banool
force-pushed
the
banool/ts_first_nft
branch
from
be81838 to
51f0e85
Compare
banool
force-pushed
the
banool/ts_first_nft
branch
from
51f0e85 to
c416eff
Compare
Forge is running with
|
banool
added a commit
that referenced
this pull request
Aug 25, 2022
0xchloe
pushed a commit
that referenced
this pull request
Aug 28, 2022
Markuze
pushed a commit
to Markuze/aptos-core
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the first NFT with SDK example to include Typescript. To facilitate this, I've done some other stuff:
directTransferTokenfunction to the TokenClient.Test Plan
SDK tests:
Examples:
Docs site:
This change is