[fix] Delta ops in TransactionOutput and ChangeSet wrappers #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This IS what I meant. Maybe a more general name like "InternalTransactionOutput", "TransactionOutputExt", etc, in case you guys introduce any other magic. |
2 tasks
georgemitenkov
force-pushed
the
george/txn-output-with-deltas
branch
from
5d8e933 to
cf0250e
Compare
zekun000
reviewed
Jul 27, 2022
georgemitenkov
force-pushed
the
george/txn-output-with-deltas
branch
from
72599dd to
dd42d3f
Compare
georgemitenkov
force-pushed
the
george/txn-output-with-deltas
branch
from
8e8b047 to
4546ad4
Compare
georgemitenkov
changed the title
georgemitenkov
force-pushed
the
george/txn-output-with-deltas
branch
from
4546ad4 to
c90dbbe
Compare
georgemitenkov
force-pushed
the
george/txn-output-with-deltas
branch
from
d802e30 to
0c53a9d
Compare
zekun000
reviewed
Jul 29, 2022
✅ Forge test success on
|
|
@zekun000 I think you forgot to approve? |
zekun000
approved these changes
Jul 29, 2022
bowenyang007
pushed a commit
to bowenyang007/aptos-core
that referenced
this pull request
Jul 29, 2022
…#2222) Fixes aptos-labs#2057. Now deltas do not escape from executor, and are stored in `TransactionOutputExt` and `ChangeSetExt` wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should help to transition from
WriteOp::Delta(..)and a number ofunreachables into a specialised transaction output and change set local to executor only.cc @msmouse @gelash. If this approach is ok,
DeltaSetwill be added and logic to handle deltas (sequential first)Test Plan
This change is