[Forge] Fix local mode forge run #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitalkedia
added
the
CICD:run-e2e-tests
rustielin
requested changes
Jul 22, 2022
| @@ -168,15 +169,19 @@ if [ -n "$AVG_TPS" ]; then | |||
| echo "forge_job_avg_tps {FORGE_CLUSTER_NAME=\"$FORGE_CLUSTER_NAME\",FORGE_NAMESPACE=\"$FORGE_NAMESPACE\",GITHUB_RUN_ID=\"$GITHUB_RUN_ID\"} $AVG_TPS" | curl -u "$PUSH_GATEWAY_USER:$PUSH_GATEWAY_PASSWORD" --data-binary @- ${PUSH_GATEWAY}/metrics/job/forge | |||
| if [[ "$AVG_TPS" -lt "$TPS_THRESHOLD" ]]; then | |||
| echo "(\!) AVG_TPS: ${avg_tps} < ${TPS_THRESHOLD} tps" | |||
| FORGE_EXIT_CODE=1 | |||
| if [ "$FORGE_RUNNER_MODE" != "local" ]; then | |||
There was a problem hiding this comment.
Can we move this perf threshold checking into the performance test itself ?
There was a problem hiding this comment.
We can do that, but that will require some plumbing in the transaction emitter. May be as a follow up I can take a look at this?
There was a problem hiding this comment.
hm ok yea. this script is just getting too complicated
sitalkedia
force-pushed
the
forge_cli_local_mode
branch
from
e8d476d to
39bc7bd
Compare
sitalkedia
force-pushed
the
forge_cli_local_mode
branch
from
39bc7bd to
2d136d3
Compare
❌ Forge test failureForge is land-blocking |
rustielin
approved these changes
Jul 22, 2022
❌ Forge test failureForge is land-blocking |
❌ Forge test failureForge is land-blocking |
❌ Forge test failureForge is land-blocking |
❌ Forge test failureForge is land-blocking |
rustielin
removed
the
CICD:run-e2e-tests
❌ Forge test failureForge is land-blocking |
✅ Forge test successForge is land-blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In local mode, submit lower TPS so that the transaction emitter is stable and also don't check for TPS/latency criteria.
Test Plan
This change is