[forge] reuse existing management configmap #2132
Merged
+107
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustielin
force-pushed
the
rustielin/forge-reuse
branch
from
f06ac5a to
13ef7df
Compare
sitalkedia
approved these changes
Jul 21, 2022
| assert!(base_num_validators <= MAX_NUM_VALIDATORS); | ||
|
|
||
| let new_era = get_new_era().unwrap(); | ||
| let new_era = "fg".to_string(); |
There was a problem hiding this comment.
nit: May be a better name instead of "fg", how about "forge_testing" ?
| if let Err(KubeError::Api(api_err)) = configmap.create(&PostParams::default(), &config).await { | ||
| if api_err.code == 409 { | ||
| info!( | ||
| "Configmap {} already exists, continuing with it", |
There was a problem hiding this comment.
Thank you for fixing this. I was meaning to put out this change but you beat me to it :)
There was a problem hiding this comment.
oops :p well Forge needs lots of improvement -- more opportunities!
❌ Forge test failureForge is land-blocking |
✅ Forge test successForge is land-blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability to reuse existing forge-management configmaps. This lets you re-run a Forge test in the same namespace as one that did not clean up properly (e.g. crashed or was
--keep). We see this crash Forge every now and then due to high test volume and high test pre-emption due to GHA triggering logic.Also introduce
forge test k8s --reuseoption, which reuses the running network (e.g. it was--keepbefore) instead of wiping the network (re-run genesis and re-install validators)Test Plan
Run on forge
This change is