[smoke-tests] Minimizing node restarts in local swarm smoke tests #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikabiljo
commented
Jul 20, 2022
Comment on lines
-387
to
-396
| let mut swarm = new_local_swarm_with_aptos(1).await; | ||
| swarm.launch().await.unwrap(); | ||
|
|
||
| // Enable state sync v2 and reboot the node | ||
| let validator = swarm.validators_mut().next().unwrap(); | ||
| let mut config = validator.config().clone(); | ||
| config.state_sync.state_sync_driver.enable_state_sync_v2 = true; | ||
| config.save(validator.config_path()).unwrap(); | ||
| validator.stop(); | ||
| swarm.launch().await.unwrap(); |
There was a problem hiding this comment.
for example, these lines were starting a node 3 times. (in new_local_swarm_with_aptos, swarm.launch() and swarm.launch after reconfig)
now they are starting it only once.
ikabiljo
force-pushed
the
ikabiljo/configure_local_swarm
branch
from
1597f6b to
d487692
Compare
- Allowing setting (per-node) validator configuration, so that we don't need to restart the node to do so - dissallowing starting already running nodes (which restarts them silently) Test plan: - all smoke tests. added test for not starting a node twice
ikabiljo
force-pushed
the
ikabiljo/configure_local_swarm
branch
from
d487692 to
61fa142
Compare
bchocho
approved these changes
Jul 21, 2022
| // Start all the validators | ||
| for validator in self.validators.values_mut() { | ||
| validator.start()?; | ||
| } | ||
|
|
||
| self.wait_all_alive(Duration::from_secs(60)).await?; | ||
| println!("Swarm launched successfully."); |
There was a problem hiding this comment.
Not for this PR, but should we have names for swarms and include them in println's to improve debugging? My understanding is we can have many swarms running in parallel.
There was a problem hiding this comment.
I don't think that is true - @zekun000 ?
| @@ -51,6 +51,21 @@ pub async fn transfer_coins( | |||
| txn | |||
| } | |||
|
|
|||
| pub async fn reconfig( | |||
There was a problem hiding this comment.
some new tests :)
it basically allows you to trigger an epoch change
✅ Forge test successForge is land-blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
This change is