[CP] Fix cargo nextest version #15608 #15624

bchocho · 2024-12-17T19:29:53Z

Fix cargo nextest version (Fix cargo nextest version #15608)

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-12-17T19:29:56Z

⏱️ 1h 45m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-unit-tests	26m	🟩
execution-performance / single-node-performance	24m	🟩
rust-move-tests	13m	🟩
forge-framework-upgrade-test / forge	11m	🟥
execution-performance / test-target-determinator	6m	🟩
rust-doc-tests	5m	🟩
test-target-determinator	5m	🟩
rust-move-tests	4m	⬜
rust-cargo-deny	4m	🟩 🟩
check-dynamic-deps	2m	🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
check	1m	🟥
general-lints	1m	🟩 🟩
semgrep/ci	53s	🟩 🟩
file_change_determinator	23s	🟩 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	24m	14m
execution-performance / test-target-determinator	6m	5m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions · 2024-12-17T20:00:20Z

✅ Forge suite `compat` success on `e07212d19a17186e03260fcc1bce53b4ffbadc64` ==> `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`

Compatibility test results for e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> eb289fccbe2d229e925abe51ea5b337eb4a7cd72 (PR)
1. Check liveness of validators at old version: e07212d19a17186e03260fcc1bce53b4ffbadc64
compatibility::simple-validator-upgrade::liveness-check : committed: 13609.30 txn/s, latency: 2087.82 ms, (p50: 1700 ms, p70: 1800, p90: 2100 ms, p99: 17800 ms), latency samples: 538660
2. Upgrading first Validator to new version: eb289fccbe2d229e925abe51ea5b337eb4a7cd72
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6885.82 txn/s, latency: 3872.92 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4800 ms), latency samples: 142160
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7210.53 txn/s, latency: 4444.33 ms, (p50: 4600 ms, p70: 4700, p90: 6100 ms, p99: 6500 ms), latency samples: 240200
3. Upgrading rest of first batch to new version: eb289fccbe2d229e925abe51ea5b337eb4a7cd72
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7118.29 txn/s, latency: 3884.85 ms, (p50: 4400 ms, p70: 4700, p90: 5100 ms, p99: 5500 ms), latency samples: 128820
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7199.83 txn/s, latency: 4554.23 ms, (p50: 4800 ms, p70: 4900, p90: 5400 ms, p99: 6400 ms), latency samples: 247880
4. upgrading second batch to new version: eb289fccbe2d229e925abe51ea5b337eb4a7cd72
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11124.11 txn/s, latency: 2521.28 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 3200 ms), latency samples: 193220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11592.40 txn/s, latency: 2776.51 ms, (p50: 2900 ms, p70: 3100, p90: 3200 ms, p99: 3400 ms), latency samples: 375040
5. check swarm health
Compatibility test for e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> eb289fccbe2d229e925abe51ea5b337eb4a7cd72 passed
Test Ok

github-actions · 2024-12-17T20:01:16Z

✅ Forge suite `realistic_env_max_load` success on `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`

two traffics test: inner traffic : committed: 15103.75 txn/s, latency: 2628.75 ms, (p50: 2700 ms, p70: 2700, p90: 2800 ms, p99: 3000 ms), latency samples: 5743100
two traffics test : committed: 99.95 txn/s, latency: 1404.52 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2300 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.475, avg: 1.347", "ConsensusProposalToOrdered: max: 0.330, avg: 0.288", "ConsensusOrderedToCommit: max: 0.371, avg: 0.354", "ConsensusProposalToCommit: max: 0.654, avg: 0.642"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.80s no progress at version 42551 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.58s no progress at version 2501865 (avg 0.58s) [limit 16].
Test Ok

trunk-io · 2024-12-17T20:44:34Z

_{View Full Report ↗︎ ⋅ Docs}

github-actions · 2024-12-18T00:13:48Z

❌ Forge suite `framework_upgrade` failure on `e07212d19a17186e03260fcc1bce53b4ffbadc64` ==> `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`

Compatibility test results for e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> eb289fccbe2d229e925abe51ea5b337eb4a7cd72 (PR)
Upgrade the nodes to version: eb289fccbe2d229e925abe51ea5b337eb4a7cd72
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 338.42 txn/s, submitted: 366.22 txn/s, failed submission: 0.79 txn/s, expired: 27.81 txn/s, latency: 1933.20 ms, (p50: 1800 ms, p70: 2100, p90: 2700 ms, p99: 4000 ms), latency samples: 111110
Test Failed: Waiting for nodes to catch up to target version and epoch (None, Some(12)) timed out after 20 seconds, current status: Ok([("validator-0", 112542, 11), ("validator-1", 112542, 11), ("validator-2", 112542, 11), ("validator-3", 112542, 11)])

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_target_version_or_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:463:24
   2: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:396:6
   3: aptos_forge::interface::swarm::SwarmExt::wait_for_all_nodes_to_change_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:289:92
   4: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   5: aptos_forge::interface::swarm::SwarmExt::fork_check::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:200:14
   6: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: <aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/framework_upgrade.rs:93:63
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  10: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  11: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  12: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  13: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  14: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  15: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  16: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  17: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  18: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:332:50
  19: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
  20: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
  21: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  22: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  23: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  24: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  25: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  26: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  27: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  28: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  29: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start
Trailing Log Lines:
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="1" errors="0" uuid="66f62430-824f-4f7c-9ac9-ed9d8f1632b9">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="1">
        <testcase name="framework_upgrade::framework-upgrade">
            <failure message="Waiting for nodes to catch up to target version and epoch (None, Some(12)) timed out after 20 seconds, current status: Ok([(&quot;validator-0&quot;, 112542, 11), (&quot;validator-1&quot;, 112542, 11), (&quot;validator-2&quot;, 112542, 11), (&quot;validator-3&quot;, 112542, 11)])

Stack backtrace:
   0: anyhow::error::&lt;impl anyhow::Error&gt;::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_target_version_or_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:463:24
   2: aptos_forge::interface::swarm::wait_for_all_nodes_to_catchup_to_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:396:6
   3: aptos_forge::interface::swarm::SwarmExt::wait_for_all_nodes_to_change_epoch::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:289:92
   4: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   5: aptos_forge::interface::swarm::SwarmExt::fork_check::{{closure}}
             at ./testsuite/forge/src/interface/swarm.rs:200:14
   6: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   7: &lt;aptos_testcases::framework_upgrade::FrameworkUpgrade as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/framework_upgrade.rs:93:63
   8: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   9: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  10: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  11: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  12: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  13: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  14: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  15: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  16: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  17: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  18: aptos_forge::runner::Forge&lt;F&gt;::run
             at ./testsuite/forge/src/runner.rs:332:50
  19: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
  20: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
  21: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  22: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  23: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  24: core::ops::function::impls::&lt;impl core::ops::function::FnOnce&lt;A&gt; for &amp;F&gt;::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  25: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  26: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  27: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  28: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  29: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  30: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  31: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  32: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  33: main
  34: __libc_start_main
  35: _start"/>
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===

Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:381"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-15624-1734480233-e07212d19a17186e032","timestamp":"2024-12-18T00:13:44.539027Z","message":"Deleting namespace forge-framework-upgrade-pr-15624: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:398"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-15624-1734480233-e07212d19a17186e032","timestamp":"2024-12-18T00:13:44.539055Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-15624"}

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:358:13
   2: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:426:24
   3: forge::main
             at ./testsuite/forge-cli/src/main.rs:329:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
   5: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
   6: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
   7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
   8: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
   9: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  10: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  12: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  15: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  16: main
  17: __libc_start_main
  18: _start
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                1/1     Running     0          7m37s
aptos-node-1-validator-0                1/1     Running     0          6m56s
aptos-node-2-validator-0                1/1     Running     0          9m44s
aptos-node-3-validator-0                1/1     Running     0          9m44s
genesis-aptos-genesis-eforge169-7w7pt   0/1     Completed   0          9m45s

Fix cargo nextest version (#15608)

eb289fc

bchocho changed the base branch from main to aptos-release-v1.25 December 17, 2024 19:30

bchocho requested review from sherry-x and igor-aptos December 17, 2024 19:30

bchocho marked this pull request as ready for review December 17, 2024 19:30

bchocho requested a review from a team as a code owner December 17, 2024 19:31

bchocho requested a review from JoshLind December 17, 2024 19:31

sionescu approved these changes Dec 17, 2024

View reviewed changes

igor-aptos approved these changes Dec 17, 2024

View reviewed changes

bchocho enabled auto-merge (squash) December 17, 2024 19:33

sherry-x approved these changes Dec 17, 2024

View reviewed changes

JoshLind approved these changes Dec 17, 2024

View reviewed changes

gregnazario approved these changes Dec 17, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

sherry-x disabled auto-merge December 18, 2024 17:47

sherry-x merged commit 6aa731e into aptos-release-v1.25 Dec 18, 2024
88 of 94 checks passed

sherry-x deleted the brian/cherry-pick-1-25 branch December 18, 2024 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP] Fix cargo nextest version #15608 #15624

[CP] Fix cargo nextest version #15608 #15624

bchocho commented Dec 17, 2024 •

edited

Loading

trunk-io bot commented Dec 17, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

trunk-io bot commented Dec 17, 2024

This comment has been minimized.

github-actions bot commented Dec 18, 2024

[CP] Fix cargo nextest version #15608 #15624

[CP] Fix cargo nextest version #15608 #15624

Conversation

bchocho commented Dec 17, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Dec 17, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 17, 2024

✅ Forge suite compat success on e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> eb289fccbe2d229e925abe51ea5b337eb4a7cd72

github-actions bot commented Dec 17, 2024

✅ Forge suite realistic_env_max_load success on eb289fccbe2d229e925abe51ea5b337eb4a7cd72

trunk-io bot commented Dec 17, 2024

This comment has been minimized.

github-actions bot commented Dec 18, 2024

❌ Forge suite framework_upgrade failure on e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> eb289fccbe2d229e925abe51ea5b337eb4a7cd72

bchocho commented Dec 17, 2024 •

edited

Loading

trunk-io bot commented Dec 17, 2024 •

edited

Loading

✅ Forge suite `compat` success on `e07212d19a17186e03260fcc1bce53b4ffbadc64` ==> `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`

✅ Forge suite `realistic_env_max_load` success on `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`

❌ Forge suite `framework_upgrade` failure on `e07212d19a17186e03260fcc1bce53b4ffbadc64` ==> `eb289fccbe2d229e925abe51ea5b337eb4a7cd72`