update yaml for v1.25 upgrade #15620
Conversation
⏱️ 42m total CI duration on this PR
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| title: "Multi-step proposal to upgrade mainnet framework, version TBD" | ||
| description: "This includes changes in (TBA: URL to changes)" | ||
| title: "Multi-step proposal to upgrade mainnet framework, version v1.25.0" | ||
| description: "This includes changes in " |
There was a problem hiding this comment.
The description field appears to be truncated after "This includes changes in". Please add the specific changes or a URL to the changelog for v1.25.0 to ensure the proposal's documentation is complete and reviewers can understand the full scope of the framework upgrade.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| - Framework: | ||
| bytecode_version: 6 | ||
| git_hash: ~ | ||
| - FeatureFlag: | ||
| enabled: | ||
| - allow_serialized_script_args | ||
|
|
||
| bytecode_version: 7 | ||
| git_hash: ~ |
There was a problem hiding this comment.
The removal of the FeatureFlag section containing allow_serialized_script_args appears to be a significant change. Please confirm that this feature flag is no longer needed in v1.25.0. If this feature is still required by any part of the system, removing it could cause runtime issues. Consider documenting the rationale for this removal in the PR description.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist