Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[execution-pool] Create iterator on TransactionShuffler #15613

Draft
wants to merge 2 commits into
base: brian/exec-window-exec-optimize-2
Choose a base branch
from
Draft

[execution-pool] Create iterator on TransactionShuffler #15613

wants to merge 2 commits into from
+1,256 −416

Conversation

hariria
Copy link
Contributor

@hariria hariria commented Dec 16, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

bchocho and others added 2 commits December 3, 2024 10:31
@bchocho
Filter committed transactions. Up until round-1 in prepare phase, and…
4419c21 
… round-1 in execution phase.

This requires using blocking txn provider to quickly provide shuffled txns in the execution phase.

Various improvements to avoid cloning transactions.
@hariria
[execution-pool] Create iterator on TransactionShuffler
4b8fb04
@trunk-io Trunk.io
Copy link

trunk-io bot commented Dec 16, 2024 •
edited
Loading

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩 
rust-cargo-deny 2m 🟩 
check-dynamic-deps 47s 🟩 
general-lints 26s 🟩 
semgrep/ci 18s 🟩 
file_change_determinator 13s 🟩 
permission-check 2s 🟩 
permission-check 2s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@hariria hariria force-pushed the brian/exec-window-exec-optimize-2 branch from 4419c21 to 20a72fe Compare December 18, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@bchocho bchocho Awaiting requested review from bchocho bchocho will be requested when the pull request is marked ready for review bchocho is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash will be requested when the pull request is marked ready for review gelash is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun ibalajiarun will be requested when the pull request is marked ready for review ibalajiarun is a code owner

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind will be requested when the pull request is marked ready for review JoshLind is a code owner

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario will be requested when the pull request is marked ready for review gregnazario is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl danielxiangzl will be requested when the pull request is marked ready for review danielxiangzl is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@georgemitenkov georgemitenkov Awaiting requested review from georgemitenkov georgemitenkov will be requested when the pull request is marked ready for review georgemitenkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariria @bchocho