Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] enable pipeline #15600

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[forge] enable pipeline #15600

merged 1 commit into from
Dec 13, 2024

Conversation

zekun000
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 13, 2024

⏱️ 55m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 4m 🟩
check-dynamic-deps 4m 🟩🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 58s 🟩🟩
semgrep/ci 51s 🟩🟩
file_change_determinator 19s 🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 8s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 2m 1m +95%
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zekun000 zekun000 enabled auto-merge (rebase) December 13, 2024 21:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 14919.80 txn/s, latency: 2157.31 ms, (p50: 1800 ms, p70: 1900, p90: 2200 ms, p99: 17900 ms), latency samples: 515620
2. Upgrading first Validator to new version: 59aab7419c867ef30c125e7b4dbf8e373ccde8b9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7419.83 txn/s, latency: 3871.63 ms, (p50: 4300 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 139040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7520.49 txn/s, latency: 4389.11 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5300 ms), latency samples: 253140
3. Upgrading rest of first batch to new version: 59aab7419c867ef30c125e7b4dbf8e373ccde8b9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5250.39 txn/s, latency: 5582.61 ms, (p50: 6100 ms, p70: 6600, p90: 6900 ms, p99: 7200 ms), latency samples: 102780
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5345.73 txn/s, latency: 6226.83 ms, (p50: 6800 ms, p70: 6900, p90: 7100 ms, p99: 7100 ms), latency samples: 184120
4. upgrading second batch to new version: 59aab7419c867ef30c125e7b4dbf8e373ccde8b9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12149.32 txn/s, latency: 2240.95 ms, (p50: 2300 ms, p70: 2600, p90: 3000 ms, p99: 3100 ms), latency samples: 211340
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12354.74 txn/s, latency: 2521.46 ms, (p50: 2400 ms, p70: 2900, p90: 3000 ms, p99: 3200 ms), latency samples: 405060
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 59aab7419c867ef30c125e7b4dbf8e373ccde8b9

two traffics test: inner traffic : committed: 14760.10 txn/s, latency: 2693.68 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5612240
two traffics test : committed: 99.89 txn/s, latency: 1424.33 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 4400 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.590, avg: 1.447", "ConsensusProposalToOrdered: max: 0.341, avg: 0.294", "ConsensusOrderedToCommit: max: 0.307, avg: 0.295", "ConsensusProposalToCommit: max: 0.595, avg: 0.588"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.07s no progress at version 8857 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 2094135 (avg 0.52s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9 (PR)
Upgrade the nodes to version: 59aab7419c867ef30c125e7b4dbf8e373ccde8b9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1380.81 txn/s, submitted: 1383.25 txn/s, failed submission: 2.44 txn/s, expired: 2.44 txn/s, latency: 2196.13 ms, (p50: 2100 ms, p70: 2400, p90: 3200 ms, p99: 4800 ms), latency samples: 124500
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1329.20 txn/s, submitted: 1332.35 txn/s, failed submission: 3.14 txn/s, expired: 3.14 txn/s, latency: 2264.63 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4400 ms), latency samples: 118380
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 59aab7419c867ef30c125e7b4dbf8e373ccde8b9 passed
Upgrade the remaining nodes to version: 59aab7419c867ef30c125e7b4dbf8e373ccde8b9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1291.28 txn/s, submitted: 1293.92 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2315.03 ms, (p50: 2400 ms, p70: 2400, p90: 3000 ms, p99: 4400 ms), latency samples: 117260
Test Ok

@zekun000 zekun000 merged commit 5371540 into main Dec 13, 2024
94 checks passed
@zekun000 zekun000 deleted the zekun/pipeline branch December 13, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants