Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace existing replay verify with new one #15589

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Dec 12, 2024

Description

  1. rename the workflow
    replay-verify.yaml --> replay-verify-legacy.yaml
    replay-verify-on-archive.yaml --> replay-verify.yaml

  2. removed the schedule runs of old workflow. still keep it in case we want to manually trigger it if new flow has issues

How Has This Been Tested?

workflow runs as expected in this PR

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 12, 2024

⏱️ 1h total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-move-tests 2m
check-dynamic-deps 2m 🟩🟩🟩
general-lints 2m 🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩
permission-check 22s 🟩🟩🟩
determine-test-metadata 17s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand marked this pull request as ready for review December 12, 2024 23:33
@areshand areshand requested a review from a team as a code owner December 12, 2024 23:33
@areshand areshand force-pushed the switch_to_new_replay_verify branch from c168fb7 to a1ed0ea Compare December 12, 2024 23:35
@areshand areshand enabled auto-merge (rebase) December 13, 2024 16:48

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a1ed0ea53777895bc42b8b3a69177331e95265dd

two traffics test: inner traffic : committed: 14799.62 txn/s, latency: 2686.27 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5627180
two traffics test : committed: 99.91 txn/s, latency: 1416.14 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2600 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.575, avg: 1.519", "ConsensusProposalToOrdered: max: 0.320, avg: 0.291", "ConsensusOrderedToCommit: max: 0.385, avg: 0.374", "ConsensusProposalToCommit: max: 0.673, avg: 0.664"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 8837 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.69s no progress at version 2065643 (avg 0.62s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd (PR)
Upgrade the nodes to version: a1ed0ea53777895bc42b8b3a69177331e95265dd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1612.06 txn/s, submitted: 1615.18 txn/s, failed submission: 3.13 txn/s, expired: 3.13 txn/s, latency: 1857.41 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 3100 ms), latency samples: 144280
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1411.11 txn/s, submitted: 1414.69 txn/s, failed submission: 3.58 txn/s, expired: 3.58 txn/s, latency: 2153.64 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4400 ms), latency samples: 126160
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd passed
Upgrade the remaining nodes to version: a1ed0ea53777895bc42b8b3a69177331e95265dd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1393.04 txn/s, submitted: 1397.04 txn/s, failed submission: 4.00 txn/s, expired: 4.00 txn/s, latency: 2141.88 ms, (p50: 2100 ms, p70: 2400, p90: 2700 ms, p99: 4500 ms), latency samples: 125360
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 17009.09 txn/s, latency: 2000.61 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 2700 ms), latency samples: 546720
2. Upgrading first Validator to new version: a1ed0ea53777895bc42b8b3a69177331e95265dd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7100.88 txn/s, latency: 4026.63 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 132620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7216.59 txn/s, latency: 4557.27 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5300 ms), latency samples: 237300
3. Upgrading rest of first batch to new version: a1ed0ea53777895bc42b8b3a69177331e95265dd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7357.96 txn/s, latency: 3874.41 ms, (p50: 4300 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 137560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3525.86 txn/s, submitted: 3526.02 txn/s, expired: 0.16 txn/s, latency: 4447.02 ms, (p50: 4800 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 248489
4. upgrading second batch to new version: a1ed0ea53777895bc42b8b3a69177331e95265dd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7882.90 txn/s, latency: 3432.48 ms, (p50: 2700 ms, p70: 4800, p90: 5700 ms, p99: 6200 ms), latency samples: 139880
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8966.43 txn/s, latency: 3404.75 ms, (p50: 2600 ms, p70: 3600, p90: 6000 ms, p99: 6500 ms), latency samples: 307040
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> a1ed0ea53777895bc42b8b3a69177331e95265dd passed
Test Ok

@areshand areshand merged commit c9b71bc into main Dec 13, 2024
95 checks passed
@areshand areshand deleted the switch_to_new_replay_verify branch December 13, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants