-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devsetup] Install the latest rust toolchain #15585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 20m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
JoshLind
force-pushed
the
install_rustc_latest
branch
from
December 12, 2024 22:44
293ad62
to
1170fba
Compare
vgao1996
approved these changes
Dec 12, 2024
sionescu
approved these changes
Dec 12, 2024
ibalajiarun
approved these changes
Dec 12, 2024
JoshLind
force-pushed
the
install_rustc_latest
branch
2 times, most recently
from
December 12, 2024 23:02
dcb635a
to
6c2cc1b
Compare
JoshLind
force-pushed
the
install_rustc_latest
branch
from
December 12, 2024 23:13
6c2cc1b
to
c7dfa43
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
dev_setup.sh
script to also install the latest rust toolchain version. This helps to ensure that we can always build the various tools that we need in CI (e.g.,nextest
,cargo-sort
, etc.), even if theaptos-core
rust version is behind the rest of the ecosystem.Testing Plan
Existing test infrastructure.