Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devsetup] Install the latest rust toolchain #15585

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Dec 12, 2024

Description

This PR updates the dev_setup.sh script to also install the latest rust toolchain version. This helps to ensure that we can always build the various tools that we need in CI (e.g., nextest, cargo-sort, etc.), even if the aptos-core rust version is behind the rest of the ecosystem.

Testing Plan

Existing test infrastructure.

@JoshLind JoshLind requested a review from a team as a code owner December 12, 2024 22:42
Copy link

trunk-io bot commented Dec 12, 2024

⏱️ 2h 20m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 17m 🟩🟩🟩🟩
test-target-determinator 16m 🟩🟩
check 15m 🟩🟥🟩🟩
rust-move-tests 12m 🟩
rust-move-tests 11m
rust-cargo-deny 10m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 10m
rust-doc-tests 7m 🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 6m 🟩
rust-doc-tests 4m
rust-move-tests 4m
general-lints 3m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 3m

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +119%
execution-performance / single-node-performance 10s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind requested a review from vgao1996 December 12, 2024 22:42
@JoshLind JoshLind assigned aluon and unassigned aluon Dec 12, 2024
@JoshLind JoshLind force-pushed the install_rustc_latest branch from 293ad62 to 1170fba Compare December 12, 2024 22:44
@JoshLind JoshLind enabled auto-merge (rebase) December 12, 2024 22:55
@JoshLind JoshLind force-pushed the install_rustc_latest branch 2 times, most recently from dcb635a to 6c2cc1b Compare December 12, 2024 23:02
@JoshLind JoshLind force-pushed the install_rustc_latest branch from 6c2cc1b to c7dfa43 Compare December 12, 2024 23:13

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c7dfa431138a24c4cdb784b601f966d56dff8a72

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c7dfa431138a24c4cdb784b601f966d56dff8a72 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 16834.84 txn/s, latency: 1998.44 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 3300 ms), latency samples: 558940
2. Upgrading first Validator to new version: c7dfa431138a24c4cdb784b601f966d56dff8a72
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7154.22 txn/s, latency: 3922.11 ms, (p50: 4300 ms, p70: 4700, p90: 4700 ms, p99: 4800 ms), latency samples: 134100
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7494.72 txn/s, latency: 4377.43 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5200 ms), latency samples: 252440
3. Upgrading rest of first batch to new version: c7dfa431138a24c4cdb784b601f966d56dff8a72
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7016.52 txn/s, latency: 4013.22 ms, (p50: 4400 ms, p70: 4700, p90: 5100 ms, p99: 5400 ms), latency samples: 133320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7371.68 txn/s, latency: 4465.50 ms, (p50: 4800 ms, p70: 4900, p90: 5200 ms, p99: 5200 ms), latency samples: 242760
4. upgrading second batch to new version: c7dfa431138a24c4cdb784b601f966d56dff8a72
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11249.89 txn/s, latency: 2410.91 ms, (p50: 2600 ms, p70: 2800, p90: 3100 ms, p99: 3300 ms), latency samples: 193240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11972.22 txn/s, latency: 2663.45 ms, (p50: 2800 ms, p70: 2800, p90: 2900 ms, p99: 3100 ms), latency samples: 388900
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> c7dfa431138a24c4cdb784b601f966d56dff8a72 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c7dfa431138a24c4cdb784b601f966d56dff8a72

two traffics test: inner traffic : committed: 14743.57 txn/s, latency: 2692.30 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5606040
two traffics test : committed: 99.98 txn/s, latency: 1445.84 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 2600 ms), latency samples: 1660
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.575, avg: 1.462", "ConsensusProposalToOrdered: max: 0.320, avg: 0.291", "ConsensusOrderedToCommit: max: 0.379, avg: 0.367", "ConsensusProposalToCommit: max: 0.668, avg: 0.658"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.64s no progress at version 44902 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.59s no progress at version 2808160 (avg 0.59s) [limit 16].
Test Ok

@JoshLind JoshLind merged commit 16db0cb into main Dec 12, 2024
48 checks passed
@JoshLind JoshLind deleted the install_rustc_latest branch December 12, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants