Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] update memory thresholds for Forge stable #15492

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ibalajiarun
Copy link
Contributor

Description

Increasing memory thresholds to accommodate #15364

Copy link

trunk-io bot commented Dec 4, 2024

⏱️ 1h 17m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
test-target-determinator 9m 🟩🟩
check-dynamic-deps 9m 🟩🟩🟩🟩
rust-move-tests 8m
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 5m 1m +302%
execution-performance / single-node-performance 9s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun changed the title wip [forge] update memory thresholds for Forge stable Dec 4, 2024
@ibalajiarun ibalajiarun added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Dec 4, 2024

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun enabled auto-merge (rebase) December 4, 2024 21:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite realistic_env_max_load success on b48e2b1586c124b945ac4dc8ce505c624dd9f0c7

two traffics test: inner traffic : committed: 14452.52 txn/s, latency: 2749.35 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5495180
two traffics test : committed: 100.02 txn/s, latency: 1983.55 ms, (p50: 1400 ms, p70: 1500, p90: 2200 ms, p99: 16300 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.112, avg: 1.383", "ConsensusProposalToOrdered: max: 0.324, avg: 0.288", "ConsensusOrderedToCommit: max: 0.376, avg: 0.361", "ConsensusProposalToCommit: max: 0.661, avg: 0.649"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.10s no progress at version 2828528 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.90s no progress at version 2828526 (avg 15.90s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7 (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 14608.84 txn/s, latency: 2355.44 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 9000 ms), latency samples: 553200
2. Upgrading first Validator to new version: b48e2b1586c124b945ac4dc8ce505c624dd9f0c7
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6610.43 txn/s, latency: 4354.97 ms, (p50: 4800 ms, p70: 5100, p90: 5300 ms, p99: 5400 ms), latency samples: 123400
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6802.00 txn/s, latency: 4762.46 ms, (p50: 5200 ms, p70: 5300, p90: 6200 ms, p99: 6600 ms), latency samples: 228040
3. Upgrading rest of first batch to new version: b48e2b1586c124b945ac4dc8ce505c624dd9f0c7
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7114.22 txn/s, latency: 3943.09 ms, (p50: 4100 ms, p70: 4500, p90: 5200 ms, p99: 5700 ms), latency samples: 134320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7163.01 txn/s, latency: 4523.38 ms, (p50: 4800 ms, p70: 4900, p90: 6100 ms, p99: 6500 ms), latency samples: 243340
4. upgrading second batch to new version: b48e2b1586c124b945ac4dc8ce505c624dd9f0c7
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12587.17 txn/s, latency: 2134.06 ms, (p50: 2200 ms, p70: 2500, p90: 2800 ms, p99: 2900 ms), latency samples: 219840
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10949.34 txn/s, latency: 2811.05 ms, (p50: 2200 ms, p70: 2800, p90: 6000 ms, p99: 7900 ms), latency samples: 352540
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7 passed
Test Ok

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite framework_upgrade success on 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7 (PR)
Upgrade the nodes to version: b48e2b1586c124b945ac4dc8ce505c624dd9f0c7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1241.69 txn/s, submitted: 1244.78 txn/s, failed submission: 3.09 txn/s, expired: 3.09 txn/s, latency: 2523.78 ms, (p50: 2100 ms, p70: 2900, p90: 4500 ms, p99: 6100 ms), latency samples: 112340
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1242.96 txn/s, submitted: 1244.72 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2365.58 ms, (p50: 1800 ms, p70: 2500, p90: 4500 ms, p99: 5900 ms), latency samples: 112760
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> b48e2b1586c124b945ac4dc8ce505c624dd9f0c7 passed
Upgrade the remaining nodes to version: b48e2b1586c124b945ac4dc8ce505c624dd9f0c7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1331.65 txn/s, submitted: 1334.01 txn/s, failed submission: 2.36 txn/s, expired: 2.36 txn/s, latency: 2403.59 ms, (p50: 2000 ms, p70: 2400, p90: 4700 ms, p99: 6200 ms), latency samples: 112940
Test Ok

@ibalajiarun ibalajiarun merged commit fe96e6d into main Dec 4, 2024
76 of 92 checks passed
@ibalajiarun ibalajiarun deleted the balaji/forge-stable-calib branch December 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants