[qs] batch store bootstrap perf improvements #15491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 41m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
ibalajiarun
force-pushed
the
balaji/qs-batch-store
branch
from
3290472 to
ab67fd5
Compare
ibalajiarun
commented
Dec 4, 2024
| Self::gc_previous_epoch_batches_from_db(db_clone, epoch); | ||
| }); | ||
| } else { | ||
| Self::populate_cache_and_gc_expired_batches( |
zekun000
approved these changes
Dec 4, 2024
bchocho
approved these changes
Dec 4, 2024
| @@ -157,7 +157,7 @@ impl BatchStore { | |||
| last_certified_time | |||
| ); | |||
| for (digest, value) in db_content { | |||
| let expiration = value.expiration(); | |||
| let expiration = value.expiration().saturating_sub(expiration_buffer_usecs); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
danielxiangzl
pushed a commit
that referenced
this pull request
Dec 12, 2024
* [qs] Use expiration buffer to cleanup during bootstrap * [qs] async gc old epoch batches from batch store * [qs] monitor! create batch store
danielxiangzl
pushed a commit
that referenced
this pull request
Dec 12, 2024
* [qs] Use expiration buffer to cleanup during bootstrap * [qs] async gc old epoch batches from batch store * [qs] monitor! create batch store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug from [consensus] sync improvements to help slow nodes sync better #15364 where the batches were not cleanup respecting the expiration buffer during bootstrap.
With [consensus] sync improvements to help slow nodes sync better #15364, doubling cache duration in batch store means bootstrap time during epoch changes is now doubled because all the batches now need to be read from storage. To avoid this, this PR introduces a separate path for epoch changes vs restarts. During epoch change, the old batches from storage are deleted asynchronously. At restarts, the batches are still cleaned up synchronously.