Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cost #15464

Merged
merged 1 commit into from
Dec 3, 2024
Merged

reduce cost #15464

merged 1 commit into from
Dec 3, 2024

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Dec 3, 2024

Description

  1. use single region snapshot
  2. remove repair disk after use

How Has This Been Tested?

run python archive_disk_utils.py --network mainnet
snapshot here are updated to single region https://console.cloud.google.com/compute/snapshots?inv=1&invt=AbjKqg&project=aptos-devinfra-0

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 3, 2024

⏱️ 1h 45m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 22m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 8m 🟩🟩🟩 (+1 more)
check-dynamic-deps 7m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 6m
rust-doc-tests 5m 🟩
check 3m 🟩
test-target-determinator 3m 🟩
execution-performance / test-target-determinator 3m 🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 2m 🟩🟩🟩 (+1 more)
fetch-last-released-docker-image-tag 2m 🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 3m 4m -27%

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand requested review from a team, geekflyer and msmouse December 3, 2024 19:07
Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write a test plan or show how this was tested?

@areshand areshand force-pushed the reduce_cost branch 2 times, most recently from fbeb658 to 9455fc1 Compare December 3, 2024 22:02
@areshand areshand enabled auto-merge (rebase) December 3, 2024 22:09

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite realistic_env_max_load success on 06166817272df44d4ab64241c04c7a48d9575297

two traffics test: inner traffic : committed: 14058.35 txn/s, latency: 2826.81 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5345280
two traffics test : committed: 100.02 txn/s, latency: 1757.23 ms, (p50: 1400 ms, p70: 1900, p90: 2200 ms, p99: 10400 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.311, avg: 1.373", "ConsensusProposalToOrdered: max: 0.323, avg: 0.294", "ConsensusOrderedToCommit: max: 0.379, avg: 0.366", "ConsensusProposalToCommit: max: 0.676, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.71s no progress at version 2016293 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.57s no progress at version 2016291 (avg 14.78s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297 (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 13209.26 txn/s, latency: 2179.24 ms, (p50: 1600 ms, p70: 1800, p90: 2100 ms, p99: 27600 ms), latency samples: 530320
2. Upgrading first Validator to new version: 06166817272df44d4ab64241c04c7a48d9575297
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7443.95 txn/s, latency: 3897.35 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4700 ms), latency samples: 143060
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7522.43 txn/s, latency: 4277.16 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 249260
3. Upgrading rest of first batch to new version: 06166817272df44d4ab64241c04c7a48d9575297
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6890.73 txn/s, latency: 4132.89 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 129180
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7042.75 txn/s, latency: 4647.88 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5300 ms), latency samples: 234680
4. upgrading second batch to new version: 06166817272df44d4ab64241c04c7a48d9575297
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10157.59 txn/s, latency: 2577.48 ms, (p50: 2600 ms, p70: 3200, p90: 3700 ms, p99: 3900 ms), latency samples: 186700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9891.24 txn/s, latency: 3104.19 ms, (p50: 2600 ms, p70: 3400, p90: 5500 ms, p99: 6900 ms), latency samples: 322900
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297 passed
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite framework_upgrade success on 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297 (PR)
Upgrade the nodes to version: 06166817272df44d4ab64241c04c7a48d9575297
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1214.71 txn/s, submitted: 1217.17 txn/s, failed submission: 2.46 txn/s, expired: 2.46 txn/s, latency: 2592.43 ms, (p50: 2100 ms, p70: 2700, p90: 4500 ms, p99: 5500 ms), latency samples: 108760
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1343.46 txn/s, submitted: 1345.45 txn/s, failed submission: 1.99 txn/s, expired: 1.99 txn/s, latency: 2213.26 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5300 ms), latency samples: 121720
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 06166817272df44d4ab64241c04c7a48d9575297 passed
Upgrade the remaining nodes to version: 06166817272df44d4ab64241c04c7a48d9575297
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1319.91 txn/s, submitted: 1322.59 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2418.83 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 6200 ms), latency samples: 117980
Test Ok

@areshand areshand merged commit 612018c into main Dec 3, 2024
90 of 92 checks passed
@areshand areshand deleted the reduce_cost branch December 3, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants