Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: rename ExecutedTrees -> LedgerSummary #15444

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Dec 2, 2024

Description

"trees" will not be accurate

How Has This Been Tested?

existing coverage

Key Areas to Review

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Validator Node

Copy link

trunk-io bot commented Dec 2, 2024

⏱️ 2h 2m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 45m 🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
check-dynamic-deps 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 5m 🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
rust-move-tests 54s
file_change_determinator 32s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@msmouse msmouse changed the title ExecutedTrees -> LedgerSummary trivial: rename ExecutedTrees -> LedgerSummary Dec 2, 2024
@msmouse msmouse marked this pull request as ready for review December 2, 2024 19:50
@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@msmouse msmouse requested a review from a team December 2, 2024 20:59
@msmouse msmouse enabled auto-merge (squash) December 2, 2024 20:59

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite realistic_env_max_load success on a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc

two traffics test: inner traffic : committed: 13734.74 txn/s, latency: 2892.47 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 5500 ms), latency samples: 5222260
two traffics test : committed: 99.95 txn/s, latency: 2449.00 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 19100 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.174, avg: 1.327", "ConsensusProposalToOrdered: max: 0.338, avg: 0.299", "ConsensusOrderedToCommit: max: 0.381, avg: 0.360", "ConsensusProposalToCommit: max: 0.676, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.16s no progress at version 2769848 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.66s no progress at version 2769846 (avg 15.66s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc (PR)
Upgrade the nodes to version: a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1334.81 txn/s, submitted: 1337.29 txn/s, failed submission: 2.48 txn/s, expired: 2.48 txn/s, latency: 2204.05 ms, (p50: 1800 ms, p70: 2300, p90: 3300 ms, p99: 5100 ms), latency samples: 118600
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1361.66 txn/s, submitted: 1363.85 txn/s, failed submission: 2.19 txn/s, expired: 2.19 txn/s, latency: 2200.25 ms, (p50: 2100 ms, p70: 2400, p90: 3400 ms, p99: 4700 ms), latency samples: 124360
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc passed
Upgrade the remaining nodes to version: a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1372.36 txn/s, submitted: 1375.28 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2206.32 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 3900 ms), latency samples: 122460
Test Ok

Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14313.66 txn/s, latency: 2349.90 ms, (p50: 2100 ms, p70: 2300, p90: 3400 ms, p99: 5600 ms), latency samples: 469880
2. Upgrading first Validator to new version: a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7086.48 txn/s, latency: 4016.55 ms, (p50: 4200 ms, p70: 4700, p90: 4800 ms, p99: 4800 ms), latency samples: 131500
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6701.75 txn/s, latency: 4785.78 ms, (p50: 4800 ms, p70: 4800, p90: 7000 ms, p99: 7200 ms), latency samples: 226260
3. Upgrading rest of first batch to new version: a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5806.35 txn/s, latency: 5063.34 ms, (p50: 5800 ms, p70: 6000, p90: 6200 ms, p99: 6300 ms), latency samples: 112240
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5810.99 txn/s, latency: 5565.41 ms, (p50: 5800 ms, p70: 6000, p90: 7000 ms, p99: 7500 ms), latency samples: 201080
4. upgrading second batch to new version: a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11447.49 txn/s, latency: 2410.09 ms, (p50: 2600 ms, p70: 2800, p90: 2800 ms, p99: 2900 ms), latency samples: 198100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10897.59 txn/s, latency: 2871.47 ms, (p50: 2800 ms, p70: 2900, p90: 4800 ms, p99: 5900 ms), latency samples: 354300
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a2b8c872e9e16b60d9e01bc57b786ab36e5e85cc passed
Test Ok

@msmouse msmouse merged commit 7110587 into main Dec 2, 2024
139 of 144 checks passed
@msmouse msmouse deleted the 1202-alden-LedgerSummary branch December 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants