remove the branch ref to default to github.ref #15425

areshand · 2024-11-28T04:13:58Z

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-28T04:14:02Z

⏱️ 3h 28m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	24m	🟩 🟩
test-target-determinator	23m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-cargo-deny	14m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-move-tests	13m	🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
replay-mainnet / run-replay-verify	12m	🟥 🟥 ⬜ 🟥 ⬜ (+1 more)
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-move-tests	10m	⬜
execution-performance / test-target-determinator	8m	🟩 🟩
check	7m	🟩 🟩
rust-move-tests	7m	⬜
rust-doc-tests	5m	🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / test-target-determinator	3m	4m
test-target-determinator	3m	4m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

.github/workflows/replay-verify-on-archive.yaml

.github/workflows/workflow-run-replay-verify-archive-storage-provision.yaml

github-actions · 2024-12-03T05:23:24Z

✅ Forge suite `realistic_env_max_load` success on `1bf7675c4365a5993320e713de55c18bde5d59b6`

two traffics test: inner traffic : committed: 13702.25 txn/s, latency: 2898.48 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3400 ms), latency samples: 5209920
two traffics test : committed: 100.09 txn/s, latency: 1968.80 ms, (p50: 1400 ms, p70: 1900, p90: 2200 ms, p99: 15600 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.445, avg: 1.558", "ConsensusProposalToOrdered: max: 0.329, avg: 0.300", "ConsensusOrderedToCommit: max: 0.383, avg: 0.370", "ConsensusProposalToCommit: max: 0.681, avg: 0.669"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.34s no progress at version 25223 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.15s no progress at version 2568948 (avg 15.15s) [limit 16].
Test Ok

github-actions · 2024-12-03T05:24:53Z

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `1bf7675c4365a5993320e713de55c18bde5d59b6`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6 (PR)
Upgrade the nodes to version: 1bf7675c4365a5993320e713de55c18bde5d59b6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1313.06 txn/s, submitted: 1314.23 txn/s, failed submission: 1.17 txn/s, expired: 1.17 txn/s, latency: 2425.49 ms, (p50: 2100 ms, p70: 2700, p90: 3700 ms, p99: 5100 ms), latency samples: 112080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1320.38 txn/s, submitted: 1321.93 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 2325.94 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5700 ms), latency samples: 119220
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6 passed
Upgrade the remaining nodes to version: 1bf7675c4365a5993320e713de55c18bde5d59b6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1280.11 txn/s, submitted: 1283.72 txn/s, failed submission: 3.60 txn/s, expired: 3.60 txn/s, latency: 2609.08 ms, (p50: 2100 ms, p70: 3000, p90: 4800 ms, p99: 7100 ms), latency samples: 113680
Test Ok

github-actions · 2024-12-03T05:25:16Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `1bf7675c4365a5993320e713de55c18bde5d59b6`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14498.59 txn/s, latency: 2037.15 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2500 ms), latency samples: 546620
2. Upgrading first Validator to new version: 1bf7675c4365a5993320e713de55c18bde5d59b6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6368.85 txn/s, latency: 4479.15 ms, (p50: 4800 ms, p70: 5100, p90: 5900 ms, p99: 6300 ms), latency samples: 123220
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6337.57 txn/s, latency: 5120.79 ms, (p50: 5400 ms, p70: 5700, p90: 6800 ms, p99: 7200 ms), latency samples: 217360
3. Upgrading rest of first batch to new version: 1bf7675c4365a5993320e713de55c18bde5d59b6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6273.77 txn/s, latency: 4496.55 ms, (p50: 5200 ms, p70: 5500, p90: 5600 ms, p99: 5600 ms), latency samples: 114060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5877.55 txn/s, latency: 5474.45 ms, (p50: 5600 ms, p70: 5600, p90: 7300 ms, p99: 7600 ms), latency samples: 218240
4. upgrading second batch to new version: 1bf7675c4365a5993320e713de55c18bde5d59b6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11330.32 txn/s, latency: 2470.01 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 3200 ms), latency samples: 195260
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11167.10 txn/s, latency: 2864.11 ms, (p50: 2800 ms, p70: 3000, p90: 3400 ms, p99: 4000 ms), latency samples: 363560
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6 passed
Test Ok

areshand requested a review from a team as a code owner November 28, 2024 04:13

areshand force-pushed the fix_branch branch from 182298c to b4ffedf Compare November 28, 2024 04:14

graphite-app bot reviewed Nov 28, 2024

View reviewed changes

.github/workflows/replay-verify-on-archive.yaml Outdated Show resolved Hide resolved

areshand force-pushed the fix_branch branch 2 times, most recently from 04e42b8 to 06fe79a Compare November 28, 2024 04:57

graphite-app bot reviewed Nov 28, 2024

View reviewed changes

.github/workflows/workflow-run-replay-verify-archive-storage-provision.yaml Show resolved Hide resolved

areshand added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Nov 28, 2024

areshand changed the title ~~remove the branch ref to default to main~~ remove the branch ref to default to github.ref Nov 28, 2024

areshand force-pushed the fix_branch branch 2 times, most recently from a6646ab to e92916a Compare November 28, 2024 05:07

msmouse approved these changes Dec 2, 2024

View reviewed changes

areshand requested a review from grao1991 December 2, 2024 19:08

grao1991 approved these changes Dec 2, 2024

View reviewed changes

areshand enabled auto-merge (rebase) December 3, 2024 04:29

This comment has been minimized.

Sign in to view

areshand disabled auto-merge December 3, 2024 04:37

areshand force-pushed the fix_branch branch from e92916a to 03b7a66 Compare December 3, 2024 04:43

remove the branch ref to default to main

1bf7675

areshand force-pushed the fix_branch branch from 03b7a66 to 1bf7675 Compare December 3, 2024 04:55

areshand enabled auto-merge (rebase) December 3, 2024 05:06

This comment has been minimized.

Sign in to view

areshand merged commit b011781 into main Dec 3, 2024
95 of 98 checks passed

areshand deleted the fix_branch branch December 3, 2024 05:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove the branch ref to default to github.ref #15425

remove the branch ref to default to github.ref #15425

areshand commented Nov 28, 2024

trunk-io bot commented Nov 28, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

remove the branch ref to default to github.ref #15425

remove the branch ref to default to github.ref #15425

Conversation

areshand commented Nov 28, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Nov 28, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2024

✅ Forge suite realistic_env_max_load success on 1bf7675c4365a5993320e713de55c18bde5d59b6

github-actions bot commented Dec 3, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6

github-actions bot commented Dec 3, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 1bf7675c4365a5993320e713de55c18bde5d59b6

trunk-io bot commented Nov 28, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `1bf7675c4365a5993320e713de55c18bde5d59b6`

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `1bf7675c4365a5993320e713de55c18bde5d59b6`

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `1bf7675c4365a5993320e713de55c18bde5d59b6`