Fix the type in V2 event name: Change `CollectionMaxiumMutate` to `CollectionMaximumMutate` #15416

junkil-park · 2024-11-27T11:53:14Z

Description

Corrected CollectionMaxiumMutate to CollectionMaximumMutate in token_event_store.move

…llectionMaximumMutate` Corrected `CollectionMaxiumMutate` to `CollectionMaximumMutate`

trunk-io · 2024-11-27T11:53:17Z

⏱️ 1h 17m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	23m	🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-doc-tests	5m	🟩
test-target-determinator	5m	🟩
execution-performance / test-target-determinator	4m	🟩
check	4m	🟩
rust-cargo-deny	4m	🟩 🟩
check-dynamic-deps	3m	🟩 🟩
fetch-last-released-docker-image-tag	1m	🟩
semgrep/ci	54s	🟩 🟩
general-lints	52s	🟩 🟩
file_change_determinator	20s	🟩 🟩
file_change_determinator	10s	🟩
permission-check	6s	🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

graphite-app · 2024-11-27T11:54:05Z

aptos-move/framework/aptos-token/doc/token_event_store.md

@@ -11,7 +11,7 @@ This module provides utils to add and emit new token events that are not in toke
 -  [Struct `CollectionUriMutateEvent`](#0x3_token_event_store_CollectionUriMutateEvent)
 -  [Struct `CollectionUriMutate`](#0x3_token_event_store_CollectionUriMutate)
 -  [Struct `CollectionMaxiumMutateEvent`](#0x3_token_event_store_CollectionMaxiumMutateEvent)
-  [Struct `CollectionMaxiumMutate`](#0x3_token_event_store_CollectionMaxiumMutate)
+-  [Struct `CollectionMaximumMutate`](#0x3_token_event_store_CollectionMaximumMutate)


The link in the table of contents needs to be updated to match the renamed struct. The current link points to #0x3_token_event_store_CollectionMaxiumMutate but should point to #0x3_token_event_store_CollectionMaximumMutate.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

davidiw · 2024-11-27T18:15:38Z

aptos-move/framework/aptos-token/sources/token_event_store.move

@@ -59,7 +59,7 @@ module aptos_token::token_event_store {

    #[event]
    /// Event emitted when the collection maximum is mutated
-    struct CollectionMaxiumMutate has drop, store {
+    struct CollectionMaximumMutate has drop, store {


won't we need both of these though... since this is already on mainnet?

@davidiw , yes, I put the old one at the end of the file: https://github.com/aptos-labs/aptos-core/pull/15416/files#diff-a248231a7241c7460f7cbcf7d963f52b1928878d184ddc841ea3d22c52c12df9R535 That seems to be the convention, right? @lightmark

yeah... I think I just remove the suffix blindly w/o checking the spelling...

github-actions · 2024-11-27T19:48:08Z

✅ Forge suite `realistic_env_max_load` success on `30ce3facba8d9b6f88c9c026027bc71194366e90`

two traffics test: inner traffic : committed: 13858.76 txn/s, latency: 2866.54 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5269400
two traffics test : committed: 99.92 txn/s, latency: 2053.96 ms, (p50: 1900 ms, p70: 2100, p90: 2300 ms, p99: 12800 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.282, avg: 1.184", "ConsensusProposalToOrdered: max: 0.330, avg: 0.297", "ConsensusOrderedToCommit: max: 0.389, avg: 0.369", "ConsensusProposalToCommit: max: 0.683, avg: 0.666"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 2373091 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.71s no progress at version 2373089 (avg 15.71s) [limit 16].
Test Ok

github-actions · 2024-11-27T19:48:32Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `30ce3facba8d9b6f88c9c026027bc71194366e90`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14751.21 txn/s, latency: 2302.02 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 6800 ms), latency samples: 478640
2. Upgrading first Validator to new version: 30ce3facba8d9b6f88c9c026027bc71194366e90
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6282.67 txn/s, latency: 4563.62 ms, (p50: 5100 ms, p70: 5500, p90: 5700 ms, p99: 5800 ms), latency samples: 116900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6208.27 txn/s, latency: 5226.82 ms, (p50: 5600 ms, p70: 5700, p90: 6800 ms, p99: 7200 ms), latency samples: 213840
3. Upgrading rest of first batch to new version: 30ce3facba8d9b6f88c9c026027bc71194366e90
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7274.18 txn/s, latency: 3903.04 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 4800 ms), latency samples: 132520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6727.05 txn/s, latency: 4841.87 ms, (p50: 4800 ms, p70: 4900, p90: 7000 ms, p99: 7300 ms), latency samples: 250380
4. upgrading second batch to new version: 30ce3facba8d9b6f88c9c026027bc71194366e90
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12855.32 txn/s, latency: 2163.01 ms, (p50: 2400 ms, p70: 2500, p90: 2500 ms, p99: 2600 ms), latency samples: 223460
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10596.61 txn/s, latency: 2693.63 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 6800 ms), latency samples: 410000
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90 passed
Test Ok

github-actions · 2024-11-27T19:50:25Z

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `30ce3facba8d9b6f88c9c026027bc71194366e90`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90 (PR)
Upgrade the nodes to version: 30ce3facba8d9b6f88c9c026027bc71194366e90
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1264.21 txn/s, submitted: 1266.45 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2343.03 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 4800 ms), latency samples: 112860
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1455.32 txn/s, submitted: 1457.81 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2216.07 ms, (p50: 1800 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 116880
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90 passed
Upgrade the remaining nodes to version: 30ce3facba8d9b6f88c9c026027bc71194366e90
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1310.28 txn/s, submitted: 1313.15 txn/s, failed submission: 2.87 txn/s, expired: 2.87 txn/s, latency: 2259.08 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5400 ms), latency samples: 118640
Test Ok

Fix the type in V2 event name: Change CollectionMaxiumMutate to `Co…

30ce3fa

…llectionMaximumMutate` Corrected `CollectionMaxiumMutate` to `CollectionMaximumMutate`

junkil-park requested a review from areshand as a code owner November 27, 2024 11:53

junkil-park requested review from lightmark, davidiw and JohnChangUK and removed request for areshand November 27, 2024 11:53

graphite-app bot reviewed Nov 27, 2024

View reviewed changes

davidiw approved these changes Nov 27, 2024

View reviewed changes

kent-white approved these changes Nov 27, 2024

View reviewed changes

JohnChangUK approved these changes Nov 27, 2024

View reviewed changes

lightmark approved these changes Nov 27, 2024

View reviewed changes

junkil-park enabled auto-merge (squash) November 27, 2024 19:22

This comment has been minimized.

Sign in to view

junkil-park merged commit d0410ec into main Nov 27, 2024
94 checks passed

junkil-park deleted the jpark/fix-collection-maximum-mutate-event branch November 27, 2024 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the type in V2 event name: Change `CollectionMaxiumMutate` to `CollectionMaximumMutate` #15416

Fix the type in V2 event name: Change `CollectionMaxiumMutate` to `CollectionMaximumMutate` #15416

junkil-park commented Nov 27, 2024 •

edited

Loading

trunk-io bot commented Nov 27, 2024 •

edited

Loading

graphite-app bot Nov 27, 2024

davidiw Nov 27, 2024

junkil-park Nov 27, 2024

lightmark Nov 27, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

Fix the type in V2 event name: Change CollectionMaxiumMutate to CollectionMaximumMutate #15416

Fix the type in V2 event name: Change CollectionMaxiumMutate to CollectionMaximumMutate #15416

Conversation

junkil-park commented Nov 27, 2024 • edited Loading

Description

trunk-io bot commented Nov 27, 2024 • edited Loading

graphite-app bot Nov 27, 2024

Choose a reason for hiding this comment

davidiw Nov 27, 2024

Choose a reason for hiding this comment

junkil-park Nov 27, 2024

Choose a reason for hiding this comment

lightmark Nov 27, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

✅ Forge suite realistic_env_max_load success on 30ce3facba8d9b6f88c9c026027bc71194366e90

github-actions bot commented Nov 27, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90

github-actions bot commented Nov 27, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 30ce3facba8d9b6f88c9c026027bc71194366e90

Fix the type in V2 event name: Change `CollectionMaxiumMutate` to `CollectionMaximumMutate` #15416

Fix the type in V2 event name: Change `CollectionMaxiumMutate` to `CollectionMaximumMutate` #15416

junkil-park commented Nov 27, 2024 •

edited

Loading

trunk-io bot commented Nov 27, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `30ce3facba8d9b6f88c9c026027bc71194366e90`

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `30ce3facba8d9b6f88c9c026027bc71194366e90`

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `30ce3facba8d9b6f88c9c026027bc71194366e90`