Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky test #15407

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix flaky test #15407

merged 2 commits into from
Dec 9, 2024

Conversation

areshand
Copy link
Contributor

Description

error is Uniform::new called with low >= high

ensure high is always greater than low now

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 26, 2024 •
edited
Loading

⏱️ 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 12m 🟩 
check-dynamic-deps 4m 🟩 🟩 
rust-cargo-deny 2m ⬜ 🟩 
semgrep/ci 53s 🟩 🟩 
general-lints 45s ⬜ 🟩 
file_change_determinator 23s 🟩 🟩 
permission-check 11s 🟩 🟩 
rust-move-tests 11s ⬜ 
permission-check 11s 🟩 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +104%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@areshand areshand added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Dec 4, 2024
@areshand areshand force-pushed the flaky_upperbound branch 2 times, most recently from 76f883a to 1fa6977 Compare December 4, 2024 18:57
msmouse
msmouse approved these changes Dec 4, 2024
View reviewed changes
storage/aptosdb/src/state_store/state_store_test.rs Outdated
@@ -466,10 +466,10 @@ proptest! {

#[test]
fn test_get_rightmost_leaf_with_sharding(
(input, batch1_size) in hash_map(any::<StateKey>(), any::<StateValue>(), 2..1000)
(input, batch1_size) in hash_map(any::<StateKey>(), any::<StateValue>(), 2..3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it back?

@areshand
Copy link
Contributor Author

areshand commented Dec 4, 2024

@grao1991 please take a look

@areshand areshand enabled auto-merge (rebase) December 4, 2024 23:33
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@areshand areshand disabled auto-merge December 9, 2024 20:15
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 17211.94 txn/s, latency: 1982.06 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2700 ms), latency samples: 553580
2. Upgrading first Validator to new version: 0c15097caaa67f6f27030db7e2d56953ff28255f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7704.79 txn/s, latency: 3757.19 ms, (p50: 4200 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 144960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7849.38 txn/s, latency: 4156.24 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5100 ms), latency samples: 259120
3. Upgrading rest of first batch to new version: 0c15097caaa67f6f27030db7e2d56953ff28255f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7843.35 txn/s, latency: 3615.14 ms, (p50: 4000 ms, p70: 4200, p90: 4500 ms, p99: 5000 ms), latency samples: 139680
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7883.22 txn/s, latency: 4135.73 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4600 ms), latency samples: 268660
4. upgrading second batch to new version: 0c15097caaa67f6f27030db7e2d56953ff28255f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12635.31 txn/s, latency: 2198.99 ms, (p50: 2200 ms, p70: 2600, p90: 2800 ms, p99: 3200 ms), latency samples: 222580
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 13263.25 txn/s, latency: 2362.74 ms, (p50: 2200 ms, p70: 2700, p90: 2900 ms, p99: 3500 ms), latency samples: 427640
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite realistic_env_max_load success on 0c15097caaa67f6f27030db7e2d56953ff28255f

two traffics test: inner traffic : committed: 14765.42 txn/s, latency: 2693.63 ms, (p50: 2400 ms, p70: 2700, p90: 3000 ms, p99: 5400 ms), latency samples: 5614160
two traffics test : committed: 99.94 txn/s, latency: 1763.71 ms, (p50: 1400 ms, p70: 1500, p90: 3000 ms, p99: 5600 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.414, avg: 1.253", "ConsensusProposalToOrdered: max: 0.319, avg: 0.292", "ConsensusOrderedToCommit: max: 0.378, avg: 0.364", "ConsensusProposalToCommit: max: 0.666, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 6324718 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.71s no progress at version 6241789 (avg 0.70s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f (PR)
Upgrade the nodes to version: 0c15097caaa67f6f27030db7e2d56953ff28255f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1378.43 txn/s, submitted: 1380.98 txn/s, failed submission: 2.55 txn/s, expired: 2.55 txn/s, latency: 2335.82 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4500 ms), latency samples: 118860
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1343.38 txn/s, submitted: 1345.81 txn/s, failed submission: 2.43 txn/s, expired: 2.43 txn/s, latency: 2306.83 ms, (p50: 1800 ms, p70: 2400, p90: 4200 ms, p99: 5000 ms), latency samples: 121400
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0c15097caaa67f6f27030db7e2d56953ff28255f passed
Upgrade the remaining nodes to version: 0c15097caaa67f6f27030db7e2d56953ff28255f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1339.66 txn/s, submitted: 1343.68 txn/s, failed submission: 4.02 txn/s, expired: 4.02 txn/s, latency: 2205.22 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4800 ms), latency samples: 120020
Test Ok

@areshand areshand merged commit e8289d1 into main Dec 9, 2024
51 checks passed
@areshand areshand deleted the flaky_upperbound branch December 9, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grao1991 grao1991 grao1991 approved these changes

@msmouse msmouse msmouse approved these changes

@lightmark lightmark Awaiting requested review from lightmark lightmark is a code owner

Assignees
No one assigned
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@areshand @msmouse @grao1991