Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prover][trivial] Fix generation of IsValid for variants with no fields #15403

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[Prover][trivial] Fix generation of IsValid for variants with no fields #15403

merged 2 commits into from
Nov 26, 2024

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Nov 26, 2024 •
edited
Loading

Description

This PR fixes the bug in boogie generator so that IsValid for a variant will return true when it has no fields.

How Has This Been Tested?

  1. existing tests;
  2. add a new test.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Move Prover

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 26, 2024 •
edited
Loading

⏱️ 1h 36m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟩 
rust-move-tests 13m 🟩 
rust-move-tests 12m 🟩 
rust-move-tests 11m ⬜ 
check-dynamic-deps 8m 🟩 🟩 🟩 🟩 
rust-cargo-deny 5m 🟩 🟩 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 4m 🟩 
execution-performance / test-target-determinator 4m 🟩 
check 4m 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 
fetch-last-released-docker-image-tag 1m 🟩 
general-lints 1m 🟩 🟩 🟩 
file_change_determinator 34s 🟩 🟩 ⬜ 🟩 
permission-check 19s 🟩 🟩 🟩 🟩 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 5m 1m +280%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@rahxephon89 Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rahxephon89 rahxephon89 changed the title create permissioned signer example [Prover] Fix generation of IsValid for variants with no fields Nov 26, 2024
@rahxephon89 rahxephon89 changed the title [Prover] Fix generation of IsValid for variants with no fields [WIP][Prover][trivial] Fix generation of IsValid for variants with no fields Nov 26, 2024
@rahxephon89 rahxephon89 changed the title [WIP][Prover][trivial] Fix generation of IsValid for variants with no fields [Prover][trivial] Fix generation of IsValid for variants with no fields Nov 26, 2024
@rahxephon89 rahxephon89 marked this pull request as ready for review November 26, 2024 07:10
@rahxephon89 rahxephon89 enabled auto-merge (squash) November 26, 2024 20:45
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 90dfce1ba3b920415a5175b5f69dec6641c8864d

two traffics test: inner traffic : committed: 14067.33 txn/s, latency: 2824.62 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5349120
two traffics test : committed: 100.02 txn/s, latency: 2352.79 ms, (p50: 1500 ms, p70: 1900, p90: 2300 ms, p99: 17900 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.498, avg: 1.439", "ConsensusProposalToOrdered: max: 0.315, avg: 0.293", "ConsensusOrderedToCommit: max: 0.379, avg: 0.368", "ConsensusProposalToCommit: max: 0.672, avg: 0.661"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 40537 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.71s no progress at version 2609925 (avg 15.71s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14561.02 txn/s, latency: 2360.38 ms, (p50: 1900 ms, p70: 2100, p90: 3100 ms, p99: 8800 ms), latency samples: 515900
2. Upgrading first Validator to new version: 90dfce1ba3b920415a5175b5f69dec6641c8864d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7302.59 txn/s, latency: 3915.58 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 135420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7137.78 txn/s, latency: 4543.96 ms, (p50: 4900 ms, p70: 5000, p90: 5400 ms, p99: 5600 ms), latency samples: 241560
3. Upgrading rest of first batch to new version: 90dfce1ba3b920415a5175b5f69dec6641c8864d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 8021.97 txn/s, latency: 3558.42 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4400 ms), latency samples: 146540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7399.08 txn/s, latency: 4379.49 ms, (p50: 4300 ms, p70: 4400, p90: 6800 ms, p99: 7100 ms), latency samples: 267520
4. upgrading second batch to new version: 90dfce1ba3b920415a5175b5f69dec6641c8864d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11658.94 txn/s, latency: 2342.76 ms, (p50: 2300 ms, p70: 2500, p90: 3800 ms, p99: 3900 ms), latency samples: 201700
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11575.78 txn/s, latency: 2686.82 ms, (p50: 2400 ms, p70: 2500, p90: 5000 ms, p99: 6600 ms), latency samples: 374340
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d (PR)
Upgrade the nodes to version: 90dfce1ba3b920415a5175b5f69dec6641c8864d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1414.12 txn/s, submitted: 1416.87 txn/s, failed submission: 2.75 txn/s, expired: 2.75 txn/s, latency: 2188.41 ms, (p50: 1800 ms, p70: 2200, p90: 3600 ms, p99: 4800 ms), latency samples: 123380
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1335.57 txn/s, submitted: 1338.44 txn/s, failed submission: 2.87 txn/s, expired: 2.87 txn/s, latency: 2153.77 ms, (p50: 2100 ms, p70: 2100, p90: 3300 ms, p99: 5200 ms), latency samples: 121020
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 90dfce1ba3b920415a5175b5f69dec6641c8864d passed
Upgrade the remaining nodes to version: 90dfce1ba3b920415a5175b5f69dec6641c8864d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1352.43 txn/s, submitted: 1354.93 txn/s, failed submission: 2.50 txn/s, expired: 2.50 txn/s, latency: 2260.44 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4500 ms), latency samples: 119000
Test Ok

@rahxephon89 rahxephon89 merged commit 0029300 into main Nov 26, 2024
82 of 92 checks passed
@rahxephon89 rahxephon89 deleted the teng/fix-prover-enum branch November 26, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runtian-zhou runtian-zhou runtian-zhou approved these changes

@vineethk vineethk vineethk approved these changes

@brmataptos brmataptos Awaiting requested review from brmataptos

@fEst1ck fEst1ck Awaiting requested review from fEst1ck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahxephon89 @vineethk @runtian-zhou