Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get progress from right db #15390

Merged
merged 2 commits into from
Dec 3, 2024
Merged

get progress from right db #15390

merged 2 commits into from
Dec 3, 2024

Conversation

areshand
Copy link
Contributor

Description

after sharding enabled, we need to get the progress from right db to resume restoring

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 1h 46m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 32m 🟥🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
check-dynamic-deps 7m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 5m 🟩🟩🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
fetch-last-released-docker-image-tag 1m 🟥
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 26m 17m +54%

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand force-pushed the fix_restore_for_sharding branch from 872e39e to a3583ca Compare November 25, 2024 23:01
@areshand areshand requested a review from msmouse November 25, 2024 23:01
@areshand areshand enabled auto-merge (rebase) November 26, 2024 23:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite realistic_env_max_load success on a87fad632564f8f552eed9665397d9e7729341af

two traffics test: inner traffic : committed: 13994.82 txn/s, latency: 2840.87 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5321120
two traffics test : committed: 100.08 txn/s, latency: 1824.01 ms, (p50: 1400 ms, p70: 2000, p90: 2100 ms, p99: 18400 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.322, avg: 1.411", "ConsensusProposalToOrdered: max: 0.310, avg: 0.293", "ConsensusOrderedToCommit: max: 0.304, avg: 0.296", "ConsensusProposalToCommit: max: 0.599, avg: 0.589"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.92s no progress at version 2581787 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.41s no progress at version 2581785 (avg 15.41s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af (PR)
Upgrade the nodes to version: a87fad632564f8f552eed9665397d9e7729341af
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 629.54 txn/s, submitted: 655.06 txn/s, failed submission: 1.38 txn/s, expired: 25.51 txn/s, latency: 7410.64 ms, (p50: 2100 ms, p70: 2400, p90: 36200 ms, p99: 37700 ms), latency samples: 64006
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1387.08 txn/s, submitted: 1390.24 txn/s, failed submission: 3.16 txn/s, expired: 3.16 txn/s, latency: 2170.57 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4700 ms), latency samples: 122720
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af passed
Upgrade the remaining nodes to version: a87fad632564f8f552eed9665397d9e7729341af
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 859.46 txn/s, submitted: 861.02 txn/s, failed submission: 1.55 txn/s, expired: 1.55 txn/s, latency: 3605.55 ms, (p50: 2400 ms, p70: 4200, p90: 7000 ms, p99: 9000 ms), latency samples: 77400
Test Ok

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 13737.62 txn/s, latency: 2470.31 ms, (p50: 2200 ms, p70: 2400, p90: 2700 ms, p99: 6700 ms), latency samples: 444420
2. Upgrading first Validator to new version: a87fad632564f8f552eed9665397d9e7729341af
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7183.72 txn/s, latency: 3902.34 ms, (p50: 4000 ms, p70: 4600, p90: 5300 ms, p99: 5600 ms), latency samples: 135700
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7153.50 txn/s, latency: 4522.07 ms, (p50: 4700 ms, p70: 4800, p90: 6200 ms, p99: 6400 ms), latency samples: 242060
3. Upgrading rest of first batch to new version: a87fad632564f8f552eed9665397d9e7729341af
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4903.10 txn/s, latency: 5844.01 ms, (p50: 6300 ms, p70: 7300, p90: 7700 ms, p99: 7900 ms), latency samples: 99580
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5250.38 txn/s, latency: 6353.65 ms, (p50: 6700 ms, p70: 7000, p90: 7400 ms, p99: 7900 ms), latency samples: 192200
4. upgrading second batch to new version: a87fad632564f8f552eed9665397d9e7729341af
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1511.89 txn/s, latency: 17146.13 ms, (p50: 19300 ms, p70: 24100, p90: 26500 ms, p99: 28600 ms), latency samples: 56140
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4424.02 txn/s, submitted: 4424.17 txn/s, expired: 0.15 txn/s, latency: 3138.40 ms, (p50: 2800 ms, p70: 3000, p90: 5600 ms, p99: 7000 ms), latency samples: 331229
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> a87fad632564f8f552eed9665397d9e7729341af passed
Test Ok

@areshand areshand merged commit 9c1f69c into main Dec 3, 2024
45 of 48 checks passed
@areshand areshand deleted the fix_restore_for_sharding branch December 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants