Verify consensus message author matches with the sender #15386

vusirikala · 2024-11-24T23:50:30Z

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-24T23:50:33Z

⏱️ 3h 40m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	20m	🟩 🟥 🟥 🟥
execution-performance / test-target-determinator	17m	🟩 🟩 🟩 🟩
test-target-determinator	17m	🟩 🟩 🟩 🟩
forge-compat-test / forge	16m	🟩
forge-e2e-test / forge	14m	🟩
check	14m	🟩 🟩 🟩 🟩
rust-move-tests	13m	🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-cargo-deny	10m	🟩 🟩 🟩 ⬜ 🟩 (+2 more)
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩 (+2 more)
fetch-last-released-docker-image-tag	6m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

manudhundi · 2024-11-25T19:00:17Z

consensus/src/epoch_manager.rs

@@ -1512,6 +1513,46 @@ impl<P: OnChainConfigProvider> EpochManager<P> {
        Ok(())
    }

+    fn check_author(&mut self, peer_id: AccountAddress, msg: &ConsensusMsg) -> anyhow::Result<()> {


Since this a bug fix, how about a test that verifies the bug is actually fixed ?

consensus/src/epoch_manager.rs

consensus/consensus-types/src/proof_of_store.rs

github-actions · 2024-12-02T23:13:55Z

✅ Forge suite `realistic_env_max_load` success on `799e44c346acc20edbfe48322fa6af3b58901d8c`

two traffics test: inner traffic : committed: 14074.78 txn/s, latency: 2824.46 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4800 ms), latency samples: 5351540
two traffics test : committed: 100.00 txn/s, latency: 1777.40 ms, (p50: 1400 ms, p70: 1900, p90: 2200 ms, p99: 14300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.120, avg: 1.328", "ConsensusProposalToOrdered: max: 0.307, avg: 0.290", "ConsensusOrderedToCommit: max: 0.369, avg: 0.358", "ConsensusProposalToCommit: max: 0.658, avg: 0.647"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.83s no progress at version 12121 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.88s no progress at version 2964415 (avg 15.88s) [limit 16].
Test Ok

github-actions · 2024-12-02T23:15:48Z

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `799e44c346acc20edbfe48322fa6af3b58901d8c`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c (PR)
Upgrade the nodes to version: 799e44c346acc20edbfe48322fa6af3b58901d8c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1067.02 txn/s, submitted: 1069.38 txn/s, failed submission: 2.36 txn/s, expired: 2.36 txn/s, latency: 2868.79 ms, (p50: 2100 ms, p70: 3000, p90: 5400 ms, p99: 8700 ms), latency samples: 90500
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1216.13 txn/s, submitted: 1218.81 txn/s, failed submission: 2.68 txn/s, expired: 2.68 txn/s, latency: 2422.59 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 6300 ms), latency samples: 108940
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c passed
Upgrade the remaining nodes to version: 799e44c346acc20edbfe48322fa6af3b58901d8c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1422.99 txn/s, submitted: 1426.54 txn/s, failed submission: 3.56 txn/s, expired: 3.56 txn/s, latency: 2122.15 ms, (p50: 2100 ms, p70: 2200, p90: 3000 ms, p99: 5000 ms), latency samples: 128080
Test Ok

github-actions · 2024-12-02T23:17:21Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `799e44c346acc20edbfe48322fa6af3b58901d8c`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14705.44 txn/s, latency: 2050.70 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 6200 ms), latency samples: 549360
2. Upgrading first Validator to new version: 799e44c346acc20edbfe48322fa6af3b58901d8c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6920.46 txn/s, latency: 4100.46 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 128320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6297.07 txn/s, latency: 4910.50 ms, (p50: 5100 ms, p70: 5100, p90: 5300 ms, p99: 7000 ms), latency samples: 239760
3. Upgrading rest of first batch to new version: 799e44c346acc20edbfe48322fa6af3b58901d8c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5907.52 txn/s, latency: 4729.14 ms, (p50: 4800 ms, p70: 5500, p90: 5800 ms, p99: 5900 ms), latency samples: 110420
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5799.38 txn/s, latency: 5554.75 ms, (p50: 5700 ms, p70: 5800, p90: 7500 ms, p99: 7600 ms), latency samples: 193260
4. upgrading second batch to new version: 799e44c346acc20edbfe48322fa6af3b58901d8c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10677.29 txn/s, latency: 2677.46 ms, (p50: 2600 ms, p70: 3000, p90: 4100 ms, p99: 4300 ms), latency samples: 203240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10587.59 txn/s, latency: 2968.94 ms, (p50: 2600 ms, p70: 3000, p90: 5700 ms, p99: 7000 ms), latency samples: 344400
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c passed
Test Ok

Two other reviewers approved

Verify commit message author matches with the sender

11b5b0a

vusirikala requested review from zekun000, sasha8 and ibalajiarun as code owners November 24, 2024 23:50

vusirikala requested review from manudhundi and danielxiangzl and removed request for sasha8 November 24, 2024 23:50

vusirikala enabled auto-merge (squash) November 24, 2024 23:51

This comment has been minimized.

Sign in to view

vusirikala changed the title ~~Verify consensus message author matches with the sender~~ [Draft] Verify consensus message author matches with the sender Nov 25, 2024

This comment has been minimized.

Sign in to view

manudhundi previously requested changes Nov 25, 2024

View reviewed changes

zekun000 reviewed Nov 25, 2024

View reviewed changes

consensus/src/epoch_manager.rs Outdated Show resolved Hide resolved

consensus/src/epoch_manager.rs Outdated Show resolved Hide resolved

Addressing PR comments

438dcb7

zekun000 reviewed Nov 25, 2024

View reviewed changes

consensus/consensus-types/src/proof_of_store.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Addressing PR comments

5e12602

vusirikala requested review from bchocho and gelash as code owners November 25, 2024 22:15

vusirikala removed request for bchocho and gelash November 25, 2024 22:18

This comment has been minimized.

Sign in to view

zekun000 approved these changes Nov 27, 2024

View reviewed changes

vusirikala requested a review from ibalajiarun December 2, 2024 18:47

Enabling optimistic sig verification

be4a116

vusirikala requested review from JoshLind and gregnazario as code owners December 2, 2024 18:48

vusirikala removed request for JoshLind and gregnazario December 2, 2024 18:49

This comment has been minimized.

Sign in to view

Merge branch 'main' into satya/check_author

799e44c

This comment has been minimized.

Sign in to view

ibalajiarun approved these changes Dec 2, 2024

View reviewed changes

vusirikala requested a review from manudhundi December 3, 2024 00:09

vusirikala merged commit 9afd783 into main Dec 3, 2024
48 checks passed

vusirikala deleted the satya/check_author branch December 3, 2024 01:09

rahxephon89 pushed a commit that referenced this pull request Dec 4, 2024

[Draft] Verify consensus message author matches with the sender (#15386)

50bd157

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify consensus message author matches with the sender #15386

Verify consensus message author matches with the sender #15386

vusirikala commented Nov 24, 2024 •

edited

Loading

trunk-io bot commented Nov 24, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

manudhundi Nov 25, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

Verify consensus message author matches with the sender #15386

Verify consensus message author matches with the sender #15386

Conversation

vusirikala commented Nov 24, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Nov 24, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

manudhundi Nov 25, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 2, 2024

✅ Forge suite realistic_env_max_load success on 799e44c346acc20edbfe48322fa6af3b58901d8c

github-actions bot commented Dec 2, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c

github-actions bot commented Dec 2, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 799e44c346acc20edbfe48322fa6af3b58901d8c

vusirikala commented Nov 24, 2024 •

edited

Loading

trunk-io bot commented Nov 24, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `799e44c346acc20edbfe48322fa6af3b58901d8c`

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `799e44c346acc20edbfe48322fa6af3b58901d8c`

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `799e44c346acc20edbfe48322fa6af3b58901d8c`