-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve compiler warning by removing unused line #15381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 17m total CI duration on this PR
|
gregnazario
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing the real work that kept bothering me :)
vineethk
approved these changes
Nov 27, 2024
Happy to contribute! :D |
alinush
force-pushed
the
resolve-compiler-warning
branch
from
December 2, 2024 19:52
102f186
to
d215c12
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an unused line from the unit test
test_events
in theaccount
module (aptos-move/framework/aptos-framework/sources/account.move
):let eventhandle = &borrow_global<Account>(addr).coin_register_events;
How to generate the warning?
To generate the warning, create a module and bring the
account
module into scope. For example:now use
aptos move test
, the following warning could be seen:How Has This Been Tested?
I removed the mentioned line locally from the unit test in the
account
module and ranaptos move test --skip-fetch-latest-git-deps
on a module similar to the one above (0x9000::test
), which resolved the compiler warningType of Change