Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-compiler-v2] remove obsolete crate testing-infra/test-generation to simplify function implementation #15354

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

brmataptos
Copy link
Contributor

Description

This was split out of https://github.com/aptos-labs/aptos-core/pull/15171 to simplify subsequent Function-related PRs.

How Has This Been Tested?

The usual.

Key Areas to Review

Does anyone still need this?

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 21, 2024

⏱️ 2h total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 32m 🟥🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
test-target-determinator 8m 🟩🟩
check 7m 🟩🟩
execution-performance / test-target-determinator 7m 🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 50s 🟩🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 26m 17m +46%
execution-performance / test-target-determinator 3m 4m -26%

settingsfeedbackdocs ⋅ learn more about trunk.io

@brmataptos brmataptos requested review from wrwg, banool, vineethk and rahxephon89 and removed request for wrwg November 21, 2024 18:50
@brmataptos brmataptos changed the title remove obsolete crate testing-infra/test-generation to simplify funciton implementation remove obsolete crate testing-infra/test-generation to simplify function implementation Nov 21, 2024
@brmataptos brmataptos changed the title remove obsolete crate testing-infra/test-generation to simplify function implementation [move-compiler-v2] remove obsolete crate testing-infra/test-generation to simplify function implementation Nov 21, 2024
@brmataptos brmataptos requested a review from vgao1996 November 21, 2024 18:54
@brmataptos brmataptos force-pushed the brm-remove-test-generation branch from ac98006 to c5e5636 Compare November 21, 2024 23:54
@brmataptos brmataptos enabled auto-merge (squash) November 21, 2024 23:54

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@brmataptos brmataptos force-pushed the brm-remove-test-generation branch from c5e5636 to 0d068a5 Compare November 22, 2024 00:24

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 0d068a551c03f186a0afec4cbb6a6b7eebe270b1

two traffics test: inner traffic : committed: 14400.53 txn/s, latency: 2761.38 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5475440
two traffics test : committed: 100.11 txn/s, latency: 1463.63 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 4500 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.064, avg: 1.570", "ConsensusProposalToOrdered: max: 0.308, avg: 0.291", "ConsensusOrderedToCommit: max: 0.373, avg: 0.363", "ConsensusProposalToCommit: max: 0.663, avg: 0.654"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.27s no progress at version 40326 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.54s no progress at version 2327011 (avg 8.54s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1

Compatibility test results for a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1 (PR)
Upgrade the nodes to version: 0d068a551c03f186a0afec4cbb6a6b7eebe270b1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1310.21 txn/s, submitted: 1312.75 txn/s, failed submission: 2.53 txn/s, expired: 2.53 txn/s, latency: 2382.07 ms, (p50: 2400 ms, p70: 2700, p90: 3300 ms, p99: 4500 ms), latency samples: 113800
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1360.88 txn/s, submitted: 1363.96 txn/s, failed submission: 3.08 txn/s, expired: 3.08 txn/s, latency: 2198.64 ms, (p50: 2100 ms, p70: 2400, p90: 3200 ms, p99: 4500 ms), latency samples: 123520
5. check swarm health
Compatibility test for a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1 passed
Upgrade the remaining nodes to version: 0d068a551c03f186a0afec4cbb6a6b7eebe270b1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1366.79 txn/s, submitted: 1368.55 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2192.64 ms, (p50: 2100 ms, p70: 2300, p90: 3000 ms, p99: 4500 ms), latency samples: 124320
Test Ok

Copy link
Contributor

✅ Forge suite compat success on a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1

Compatibility test results for a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1 (PR)
1. Check liveness of validators at old version: a734d235af377347196f25d90291df51a23915b5
compatibility::simple-validator-upgrade::liveness-check : committed: 13245.58 txn/s, latency: 2601.88 ms, (p50: 1700 ms, p70: 1900, p90: 3000 ms, p99: 25600 ms), latency samples: 491620
2. Upgrading first Validator to new version: 0d068a551c03f186a0afec4cbb6a6b7eebe270b1
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6903.82 txn/s, latency: 4124.33 ms, (p50: 4600 ms, p70: 5000, p90: 5500 ms, p99: 5700 ms), latency samples: 128240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6960.19 txn/s, latency: 4661.33 ms, (p50: 4900 ms, p70: 5100, p90: 6200 ms, p99: 6800 ms), latency samples: 233320
3. Upgrading rest of first batch to new version: 0d068a551c03f186a0afec4cbb6a6b7eebe270b1
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6354.33 txn/s, latency: 4408.79 ms, (p50: 4900 ms, p70: 5300, p90: 5700 ms, p99: 5900 ms), latency samples: 113660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6664.01 txn/s, latency: 4872.76 ms, (p50: 5100 ms, p70: 5300, p90: 6700 ms, p99: 7100 ms), latency samples: 222120
4. upgrading second batch to new version: 0d068a551c03f186a0afec4cbb6a6b7eebe270b1
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10368.13 txn/s, latency: 2602.32 ms, (p50: 2400 ms, p70: 3200, p90: 3900 ms, p99: 4300 ms), latency samples: 183720
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9859.85 txn/s, latency: 3100.53 ms, (p50: 2500 ms, p70: 3600, p90: 5600 ms, p99: 7400 ms), latency samples: 326120
5. check swarm health
Compatibility test for a734d235af377347196f25d90291df51a23915b5 ==> 0d068a551c03f186a0afec4cbb6a6b7eebe270b1 passed
Test Ok

@brmataptos brmataptos merged commit e757e26 into main Nov 22, 2024
48 checks passed
@brmataptos brmataptos deleted the brm-remove-test-generation branch November 22, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants