-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-compiler-v2] remove obsolete crate testing-infra/test-generation to simplify function implementation #15354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
brmataptos
requested review from
wrwg,
banool,
vineethk and
rahxephon89
and removed request for
wrwg
November 21, 2024 18:50
brmataptos
changed the title
remove obsolete crate testing-infra/test-generation to simplify funciton implementation
remove obsolete crate testing-infra/test-generation to simplify function implementation
Nov 21, 2024
brmataptos
changed the title
remove obsolete crate testing-infra/test-generation to simplify function implementation
[move-compiler-v2] remove obsolete crate testing-infra/test-generation to simplify function implementation
Nov 21, 2024
georgemitenkov
approved these changes
Nov 21, 2024
rahxephon89
approved these changes
Nov 21, 2024
brmataptos
force-pushed
the
brm-remove-test-generation
branch
from
November 21, 2024 23:54
ac98006
to
c5e5636
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ton implementation
brmataptos
force-pushed
the
brm-remove-test-generation
branch
from
November 22, 2024 00:24
c5e5636
to
0d068a5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was split out of
https://github.com/aptos-labs/aptos-core/pull/15171
to simplify subsequent Function-related PRs.How Has This Been Tested?
The usual.
Key Areas to Review
Does anyone still need this?
Type of Change
Which Components or Systems Does This Change Impact?
Checklist