[cp][aptos-release-v1.24] [loader-v2] Small cleanups & tests

[github-actions]

Backport

This will backport the following commits from main to aptos-release-v1.24:

• [loader-v2] Small cleanups & tests (#15279)

Questions ?

Please refer to the Backport tool documentation

[trunk-io]

⏱️ 1h 24m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	25m	🟩
rust-unit-tests	22m	🟩
rust-move-tests	9m	🟩
check-dynamic-deps	5m	🟩
rust-doc-tests	5m	🟩
execution-performance / test-target-determinator	5m	🟩
test-target-determinator	4m	🟩
check	4m	🟩
rust-cargo-deny	2m	🟩
fetch-last-released-docker-image-tag	2m	🟩
general-lints	39s	🟩
semgrep/ci	28s	🟩
file_change_determinator	13s	🟩
file_change_determinator	10s	🟩
permission-check	2s	🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
check-dynamic-deps	5m	1m
execution-performance / single-node-performance	25m	17m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on ca56d05f74ce1c7f18c2f489da4c34117d598ac1

two traffics test: inner traffic : committed: 14594.60 txn/s, latency: 2724.86 ms, (p50: 2700 ms, p70: 2700, p90: 2800 ms, p99: 3000 ms), latency samples: 5549240
two traffics test : committed: 100.05 txn/s, latency: 1733.33 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 11700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.986, avg: 1.531", "ConsensusProposalToOrdered: max: 0.325, avg: 0.291", "ConsensusOrderedToCommit: max: 0.374, avg: 0.361", "ConsensusProposalToCommit: max: 0.663, avg: 0.652"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.00s no progress at version 38015 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.42s no progress at version 2525889 (avg 8.42s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1 (PR)
1. Check liveness of validators at old version: 78db50320d1ba1ca1a61adb189b0b4fde0098f27
compatibility::simple-validator-upgrade::liveness-check : committed: 15571.48 txn/s, latency: 2086.58 ms, (p50: 1900 ms, p70: 2000, p90: 2100 ms, p99: 7600 ms), latency samples: 587560
2. Upgrading first Validator to new version: ca56d05f74ce1c7f18c2f489da4c34117d598ac1
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5114.70 txn/s, latency: 5705.42 ms, (p50: 4300 ms, p70: 8000, p90: 8900 ms, p99: 9300 ms), latency samples: 96440
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7284.91 txn/s, latency: 4371.88 ms, (p50: 4400 ms, p70: 4500, p90: 6400 ms, p99: 6500 ms), latency samples: 239160
3. Upgrading rest of first batch to new version: ca56d05f74ce1c7f18c2f489da4c34117d598ac1
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7143.80 txn/s, latency: 3836.10 ms, (p50: 4400 ms, p70: 4700, p90: 5000 ms, p99: 5200 ms), latency samples: 129760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7214.08 txn/s, latency: 4398.55 ms, (p50: 4500 ms, p70: 4700, p90: 6600 ms, p99: 6800 ms), latency samples: 239960
4. upgrading second batch to new version: ca56d05f74ce1c7f18c2f489da4c34117d598ac1
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6679.11 txn/s, latency: 4263.31 ms, (p50: 3500 ms, p70: 6000, p90: 7000 ms, p99: 7200 ms), latency samples: 115060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11371.92 txn/s, latency: 2764.21 ms, (p50: 2500 ms, p70: 2700, p90: 4600 ms, p99: 5900 ms), latency samples: 368280
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1 (PR)
Upgrade the nodes to version: ca56d05f74ce1c7f18c2f489da4c34117d598ac1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1316.57 txn/s, submitted: 1319.67 txn/s, failed submission: 3.11 txn/s, expired: 3.11 txn/s, latency: 2433.50 ms, (p50: 2100 ms, p70: 2400, p90: 4700 ms, p99: 6000 ms), latency samples: 118720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1358.92 txn/s, submitted: 1362.33 txn/s, failed submission: 3.41 txn/s, expired: 3.41 txn/s, latency: 2222.38 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4400 ms), latency samples: 119660
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> ca56d05f74ce1c7f18c2f489da4c34117d598ac1 passed
Upgrade the remaining nodes to version: ca56d05f74ce1c7f18c2f489da4c34117d598ac1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1442.37 txn/s, submitted: 1444.85 txn/s, failed submission: 2.47 txn/s, expired: 2.47 txn/s, latency: 2144.27 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4200 ms), latency samples: 128380
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking