Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-v2] Test case reduced from move-stdlib showing opportunity for optimization #15338

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Nov 20, 2024

Description

Adds a test case to support the description in the issue: #15339.

This test case was reduced from a function (vector::reverse_append) in move stdlib.

How Has This Been Tested?

Test added.

Copy link

trunk-io bot commented Nov 20, 2024

⏱️ 2h 49m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 46m 🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩 (+1 more)
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+2 more)
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 9m 🟩🟩
rust-move-tests 8m
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk force-pushed the vk/move-stdlib-reduced-testcase branch 2 times, most recently from 7e7eae7 to 2e628e0 Compare November 22, 2024 13:37
@vineethk vineethk marked this pull request as ready for review November 22, 2024 13:39
@vineethk vineethk enabled auto-merge (squash) November 25, 2024 18:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@vineethk vineethk disabled auto-merge November 25, 2024 20:53
@vineethk vineethk force-pushed the vk/move-stdlib-reduced-testcase branch from bf6fb60 to 2b38242 Compare November 25, 2024 20:56
@vineethk vineethk enabled auto-merge (squash) November 25, 2024 20:57

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2b382427e897f529ede1956160e73c5897d98909

two traffics test: inner traffic : committed: 14021.02 txn/s, latency: 2836.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 9700 ms), latency samples: 5331120
two traffics test : committed: 99.94 txn/s, latency: 2047.66 ms, (p50: 2000 ms, p70: 2200, p90: 2400 ms, p99: 6800 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.922, avg: 1.102", "ConsensusProposalToOrdered: max: 0.323, avg: 0.296", "ConsensusOrderedToCommit: max: 0.376, avg: 0.365", "ConsensusProposalToCommit: max: 0.670, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 2167381 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.52s no progress at version 2167379 (avg 15.52s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 13745.84 txn/s, latency: 2121.53 ms, (p50: 1800 ms, p70: 1900, p90: 2200 ms, p99: 16600 ms), latency samples: 548140
2. Upgrading first Validator to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7845.80 txn/s, latency: 3571.68 ms, (p50: 4000 ms, p70: 4300, p90: 4700 ms, p99: 5000 ms), latency samples: 137780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7888.42 txn/s, latency: 4086.78 ms, (p50: 4200 ms, p70: 4400, p90: 5900 ms, p99: 6100 ms), latency samples: 258560
3. Upgrading rest of first batch to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7022.80 txn/s, latency: 4066.54 ms, (p50: 4600 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 130660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6525.79 txn/s, latency: 4931.75 ms, (p50: 5000 ms, p70: 5200, p90: 7000 ms, p99: 7400 ms), latency samples: 217640
4. upgrading second batch to new version: 2b382427e897f529ede1956160e73c5897d98909
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12244.02 txn/s, latency: 2277.89 ms, (p50: 2600 ms, p70: 2600, p90: 2700 ms, p99: 2700 ms), latency samples: 212220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10446.21 txn/s, latency: 2970.66 ms, (p50: 2700 ms, p70: 2800, p90: 5700 ms, p99: 7100 ms), latency samples: 337600
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 (PR)
Upgrade the nodes to version: 2b382427e897f529ede1956160e73c5897d98909
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1407.33 txn/s, submitted: 1409.54 txn/s, failed submission: 2.21 txn/s, expired: 2.21 txn/s, latency: 2192.12 ms, (p50: 2100 ms, p70: 2300, p90: 3300 ms, p99: 5100 ms), latency samples: 127200
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1365.44 txn/s, submitted: 1368.09 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2161.80 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4700 ms), latency samples: 123660
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2b382427e897f529ede1956160e73c5897d98909 passed
Upgrade the remaining nodes to version: 2b382427e897f529ede1956160e73c5897d98909
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.07 txn/s, submitted: 1366.33 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2285.26 ms, (p50: 2100 ms, p70: 2400, p90: 3700 ms, p99: 4500 ms), latency samples: 121220
Test Ok

@vineethk vineethk merged commit 9387428 into main Nov 25, 2024
87 of 92 checks passed
@vineethk vineethk deleted the vk/move-stdlib-reduced-testcase branch November 25, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants