Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include hidden files in smoke test log upload #15333

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Nov 20, 2024

Description

Include hidden files when uploading artifacts. This behavior was changed in upload-artifact@v4

How Has This Been Tested?

See artifacts in
https://github.com/aptos-labs/aptos-core/actions/runs/11939406164/job/33279891859?pr=15333

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 20, 2024
Copy link

trunk-io bot commented Nov 20, 2024

⏱️ 2h 12m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-smoke-tests 27m 🟩
execution-performance / test-target-determinator 18m 🟩🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-doc-tests 9m 🟩🟩
test-target-determinator 9m 🟩🟩
check 8m 🟥🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 4m 🟩🟩
rust-lints 4m 🟩
check-dynamic-deps 3m 🟩🟩🟩🟩
rust-build-cached-packages 2m 🟩
rust-targeted-unit-tests 2m 🟩
general-lints 2m 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon force-pushed the aluon/push-pvsnzqwzswnu branch from 2a458e2 to 66f02e8 Compare November 20, 2024 18:21

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@aluon aluon requested review from bchocho, rustielin and a team November 20, 2024 18:55
@aluon aluon marked this pull request as ready for review November 20, 2024 18:55
@aluon aluon requested a review from a team as a code owner November 20, 2024 18:55
@aluon aluon requested a review from sionescu November 20, 2024 18:56
@aluon aluon enabled auto-merge (squash) November 20, 2024 19:21

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 66f02e854cf3e527a7eab149f850563804d0bfc0

two traffics test: inner traffic : committed: 14381.79 txn/s, latency: 2765.90 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5468260
two traffics test : committed: 100.06 txn/s, latency: 1401.99 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1700 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.020, avg: 1.565", "ConsensusProposalToOrdered: max: 0.320, avg: 0.293", "ConsensusOrderedToCommit: max: 0.380, avg: 0.369", "ConsensusProposalToCommit: max: 0.673, avg: 0.662"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 42955 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.70s no progress at version 2350599 (avg 8.70s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0

Compatibility test results for 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0 (PR)
Upgrade the nodes to version: 66f02e854cf3e527a7eab149f850563804d0bfc0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1232.77 txn/s, submitted: 1235.03 txn/s, failed submission: 2.26 txn/s, expired: 2.26 txn/s, latency: 2603.85 ms, (p50: 2100 ms, p70: 2400, p90: 5100 ms, p99: 6300 ms), latency samples: 109100
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1182.80 txn/s, submitted: 1185.03 txn/s, failed submission: 2.23 txn/s, expired: 2.23 txn/s, latency: 2541.57 ms, (p50: 2100 ms, p70: 2700, p90: 4800 ms, p99: 6600 ms), latency samples: 106100
5. check swarm health
Compatibility test for 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0 passed
Upgrade the remaining nodes to version: 66f02e854cf3e527a7eab149f850563804d0bfc0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1366.02 txn/s, submitted: 1368.56 txn/s, failed submission: 2.53 txn/s, expired: 2.53 txn/s, latency: 2279.26 ms, (p50: 2100 ms, p70: 2500, p90: 3300 ms, p99: 5100 ms), latency samples: 118600
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0

Compatibility test results for 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0 (PR)
1. Check liveness of validators at old version: 7f9825b598e86c97526ffe2c796ee17b565f933a
compatibility::simple-validator-upgrade::liveness-check : committed: 14336.82 txn/s, latency: 2401.13 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 8100 ms), latency samples: 536280
2. Upgrading first Validator to new version: 66f02e854cf3e527a7eab149f850563804d0bfc0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7064.67 txn/s, latency: 3977.66 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 5000 ms), latency samples: 129120
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6801.67 txn/s, latency: 4672.20 ms, (p50: 4900 ms, p70: 5000, p90: 7000 ms, p99: 7200 ms), latency samples: 224620
3. Upgrading rest of first batch to new version: 66f02e854cf3e527a7eab149f850563804d0bfc0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6284.89 txn/s, latency: 4541.38 ms, (p50: 5300 ms, p70: 5500, p90: 5600 ms, p99: 5600 ms), latency samples: 114540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6732.96 txn/s, latency: 4801.98 ms, (p50: 5200 ms, p70: 5400, p90: 6000 ms, p99: 6600 ms), latency samples: 230380
4. upgrading second batch to new version: 66f02e854cf3e527a7eab149f850563804d0bfc0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12169.83 txn/s, latency: 2283.38 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 210200
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10650.02 txn/s, latency: 2925.26 ms, (p50: 2600 ms, p70: 2700, p90: 5900 ms, p99: 7200 ms), latency samples: 341060
5. check swarm health
Compatibility test for 7f9825b598e86c97526ffe2c796ee17b565f933a ==> 66f02e854cf3e527a7eab149f850563804d0bfc0 passed
Test Ok

@aluon aluon merged commit 389c6c1 into main Nov 20, 2024
92 of 93 checks passed
@aluon aluon deleted the aluon/push-pvsnzqwzswnu branch November 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants