Remove the "remove_error_details" change #15331

areshand · 2024-11-20T17:31:20Z

Description

withdrew this change due to negative ecosystem impact after the discussion

How Has This Been Tested?

Existing tests

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-20T17:31:23Z

⏱️ 8h 49m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	3h 19m	🟥 🟩 🟩 🟩 🟩 (+4 more)
test-target-determinator	41m	🟩 🟩 🟩 🟩 🟩 (+4 more)
execution-performance / test-target-determinator	39m	🟩 🟩 🟩 🟩 🟩 (+4 more)
check	33m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-cargo-deny	22m	🟩 🟩 🟩 🟩 🟩 (+8 more)
fetch-last-released-docker-image-tag	15m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-tests	14m	🟥 🟥
check-dynamic-deps	13m	🟩 🟩 🟩 🟩 🟩 (+8 more)
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-move-tests	9m	🟥
rust-move-tests	8m	🟥
rust-move-tests	8m	🟥
rust-move-tests	7m	🟥
rust-move-tests	7m	🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	26m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

graphite-app · 2024-11-21T22:35:27Z

storage/aptosdb/src/db/include/aptosdb_writer.rs

@@ -489,6 +483,7 @@ impl AptosDB {
        Ok(root_hash)
    }

+    #[allow(dead_code)]


The #[allow(dead_code)] annotation appears incorrect since commit_transaction_auxiliary_data() is called in the commit_chunk_impl() method. Consider removing this annotation or documenting why this function appears unused if there are special circumstances around its usage pattern.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

types/src/transaction/mod.rs

georgemitenkov · 2024-11-21T23:34:37Z

types/src/on_chain_config/aptos_features.rs

@@ -163,7 +163,6 @@ impl FeatureFlag {
            FeatureFlag::COIN_TO_FUNGIBLE_ASSET_MIGRATION,
            FeatureFlag::OBJECT_NATIVE_DERIVED_ADDRESS,
            FeatureFlag::DISPATCHABLE_FUNGIBLE_ASSET,
-            FeatureFlag::REMOVE_DETAILED_ERROR_FROM_HASH,


can we also remove is_remove_detailed_error_from_hash_enabled? Also we can rename the feature flag to indicate this is unused?

we probably shouldn't remove feature and thus its corresponding functions. I added a comment to indicate this feature is not used.

nit: I think you can just call the feature flag as _DEPRECATED_... - we already have this for transaction fees and DKG feature flags. Better than the comment because it is explicitly deprecated. I would still prefer to remove is_remove_detailed_error_from_hash_enabled because if feature is removed, it should not have public APIs

storage/aptosdb/src/db/include/aptosdb_writer.rs

aptos-move/e2e-testsuite/proptest-regressions/tests/account_universe/peer_to_peer.txt

types/src/transaction/mod.rs

aptos-move/aptos-vm/src/aptos_vm.rs

georgemitenkov

Approved by mistake, want to comment only😄 requesting changes to override

areshand · 2024-12-03T18:51:49Z

@msmouse pls take a look when you have time

msmouse · 2024-12-03T22:08:45Z

aptos-move/aptos-release-builder/src/components/feature_flags.rs

@@ -285,7 +285,9 @@ impl From<FeatureFlag> for AptosFeatureFlag {
            FeatureFlag::ReconfigureWithDkg => AptosFeatureFlag::_DEPRECATED_RECONFIGURE_WITH_DKG,
            FeatureFlag::KeylessAccounts => AptosFeatureFlag::KEYLESS_ACCOUNTS,
            FeatureFlag::KeylessButZklessAccounts => AptosFeatureFlag::KEYLESS_BUT_ZKLESS_ACCOUNTS,
-            FeatureFlag::RemoveDetailedError => AptosFeatureFlag::REMOVE_DETAILED_ERROR_FROM_HASH,
+            FeatureFlag::RemoveDetailedError => {


this can be renamed to _deprecated_XX as well?

thought of this. But see others like this https://github.com/aptos-labs/aptos-core/blob/deprecate_related_changes/aptos-move/aptos-release-builder/src/components/feature_flags.rs#L219 not adding _deprecated. want to keep it consistent.

execution/executor-benchmark/src/lib.rs

github-actions · 2024-12-04T04:13:46Z

✅ Forge suite `realistic_env_max_load` success on `f4ab996adc6700c272ec148ba32e35b3c6c03f91`

two traffics test: inner traffic : committed: 14166.82 txn/s, latency: 2804.76 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5386540
two traffics test : committed: 100.07 txn/s, latency: 2105.32 ms, (p50: 1600 ms, p70: 2000, p90: 2200 ms, p99: 15900 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.140, avg: 1.280", "ConsensusProposalToOrdered: max: 0.328, avg: 0.292", "ConsensusOrderedToCommit: max: 0.375, avg: 0.362", "ConsensusProposalToCommit: max: 0.663, avg: 0.654"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 2235205 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.69s no progress at version 2235203 (avg 15.69s) [limit 16].
Test Ok

github-actions · 2024-12-04T04:14:29Z

✅ Forge suite `compat` success on `3527aa2e299553b759c515d9843586bad48c802c` ==> `f4ab996adc6700c272ec148ba32e35b3c6c03f91`

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> f4ab996adc6700c272ec148ba32e35b3c6c03f91 (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 13956.60 txn/s, latency: 2271.06 ms, (p50: 2000 ms, p70: 2100, p90: 2700 ms, p99: 8600 ms), latency samples: 545000
2. Upgrading first Validator to new version: f4ab996adc6700c272ec148ba32e35b3c6c03f91
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6628.23 txn/s, latency: 4339.22 ms, (p50: 4900 ms, p70: 5200, p90: 5300 ms, p99: 5400 ms), latency samples: 122740
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6145.90 txn/s, latency: 5242.60 ms, (p50: 5400 ms, p70: 5500, p90: 7100 ms, p99: 7400 ms), latency samples: 210100
3. Upgrading rest of first batch to new version: f4ab996adc6700c272ec148ba32e35b3c6c03f91
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7329.80 txn/s, latency: 3896.38 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 136960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6810.44 txn/s, latency: 4785.41 ms, (p50: 4800 ms, p70: 4800, p90: 6900 ms, p99: 7300 ms), latency samples: 253660
4. upgrading second batch to new version: f4ab996adc6700c272ec148ba32e35b3c6c03f91
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10297.91 txn/s, latency: 2689.14 ms, (p50: 2800 ms, p70: 3200, p90: 3600 ms, p99: 3800 ms), latency samples: 181480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10211.18 txn/s, latency: 3094.05 ms, (p50: 2800 ms, p70: 3300, p90: 5100 ms, p99: 6000 ms), latency samples: 333560
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> f4ab996adc6700c272ec148ba32e35b3c6c03f91 passed
Test Ok

github-actions · 2024-12-04T04:14:52Z

✅ Forge suite `framework_upgrade` success on `3527aa2e299553b759c515d9843586bad48c802c` ==> `f4ab996adc6700c272ec148ba32e35b3c6c03f91`

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> f4ab996adc6700c272ec148ba32e35b3c6c03f91 (PR)
Upgrade the nodes to version: f4ab996adc6700c272ec148ba32e35b3c6c03f91
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.80 txn/s, submitted: 1368.34 txn/s, failed submission: 3.54 txn/s, expired: 3.54 txn/s, latency: 2201.34 ms, (p50: 1800 ms, p70: 2300, p90: 3600 ms, p99: 4700 ms), latency samples: 123420
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1335.08 txn/s, submitted: 1337.97 txn/s, failed submission: 2.90 txn/s, expired: 2.90 txn/s, latency: 2174.10 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 4800 ms), latency samples: 119840
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> f4ab996adc6700c272ec148ba32e35b3c6c03f91 passed
Upgrade the remaining nodes to version: f4ab996adc6700c272ec148ba32e35b3c6c03f91
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1439.42 txn/s, submitted: 1441.68 txn/s, failed submission: 2.26 txn/s, expired: 2.26 txn/s, latency: 2263.64 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5400 ms), latency samples: 127520
Test Ok

areshand requested review from msmouse and grao1991 November 20, 2024 17:31

areshand force-pushed the deprecate_related_changes branch from 6257556 to 86056a3 Compare November 21, 2024 18:23

areshand requested review from lightmark, davidiw, wrwg, zekun000, vgao1996 and georgemitenkov as code owners November 21, 2024 18:23

areshand changed the title ~~Remove error detail from default feature list~~ Remove the "remove_error_details" change Nov 21, 2024

areshand force-pushed the deprecate_related_changes branch 2 times, most recently from 632487e to 0f9c1d0 Compare November 21, 2024 19:10

areshand enabled auto-merge (rebase) November 21, 2024 19:11