[CI][Compiler-v2] add `MOVE_LANGUAGE_V2=true` to move_pr.sh #15309

rahxephon89 · 2024-11-18T22:42:51Z

Description

Add MOVE_LANGUAGE_V2=true for compiler v2 integration tests to allow V2 language features to be implemented in aptos-framework

How Has This Been Tested?

existing tests

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-11-18T22:42:54Z

⏱️ 2h 31m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	23m	🟩
rust-move-tests	13m	🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
rust-cargo-deny	12m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-move-tests	12m	🟩
rust-move-tests	10m	🟥
rust-move-tests	10m	🟥
check-dynamic-deps	9m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-doc-tests	5m	🟩
check	4m	🟩
execution-performance / test-target-determinator	3m	🟩
test-target-determinator	3m	🟩
general-lints	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / test-target-determinator	3m	4m
test-target-determinator	3m	4m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

rahxephon89 · 2024-11-18T22:43:07Z

[CI][Compiler-v2] add MOVE_LANGUAGE_V2=true to move_pr.sh #15309 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

vineethk

Left some minor comments, LGTM otherwise.

vineethk · 2024-11-19T11:19:16Z

aptos-move/e2e-move-tests/src/lib.rs

@@ -60,5 +60,10 @@ pub(crate) fn build_package_with_compiler_version(
 ) -> anyhow::Result<BuiltPackage> {
    let mut options = options;
    options.compiler_version = Some(compiler_version);
+    if options.compiler_version.unwrap() != CompilerVersion::V1 {


Instead of unwrapping the just now set options.compiler_version, use compiler_version (the param) instead?

vineethk · 2024-11-19T11:20:26Z

aptos-move/e2e-move-tests/src/lib.rs

@@ -60,5 +60,10 @@ pub(crate) fn build_package_with_compiler_version(
 ) -> anyhow::Result<BuiltPackage> {
    let mut options = options;
    options.compiler_version = Some(compiler_version);
+    if options.compiler_version.unwrap() != CompilerVersion::V1 {
+        options.language_version = Some(move_model::metadata::LanguageVersion::latest_stable());


importing move_model::...::LanguageVersion might be better here.

vineethk · 2024-11-19T11:22:31Z

aptos-move/e2e-move-tests/src/lib.rs

+        options.language_version = Some(move_model::metadata::LanguageVersion::latest_stable());
+    } else {
+        options.language_version = Some(move_model::metadata::LanguageVersion::V1);
+    }


nit: we may want to add something like infer_language_version(compiler_version: CompilerVersion) if this pattern is going to show up regularly (which it might, similarly to inferring bytecode version).

github-actions · 2024-11-19T21:33:12Z

✅ Forge suite `realistic_env_max_load` success on `5ffa738c197007d5c6e348033d57c8379e22c7bd`

two traffics test: inner traffic : committed: 14296.20 txn/s, latency: 2779.26 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4200 ms), latency samples: 5435760
two traffics test : committed: 99.96 txn/s, latency: 1472.26 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 6300 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.010, avg: 1.591", "ConsensusProposalToOrdered: max: 0.323, avg: 0.294", "ConsensusOrderedToCommit: max: 0.381, avg: 0.367", "ConsensusProposalToCommit: max: 0.674, avg: 0.661"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.19s no progress at version 4323879 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.56s no progress at version 2677732 (avg 8.56s) [limit 15].
Test Ok

github-actions · 2024-11-19T21:35:01Z

✅ Forge suite `framework_upgrade` success on `be3ccc58ef518259d63fab7f3e3613f2a6214268` ==> `5ffa738c197007d5c6e348033d57c8379e22c7bd`

Compatibility test results for be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd (PR)
Upgrade the nodes to version: 5ffa738c197007d5c6e348033d57c8379e22c7bd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1506.36 txn/s, submitted: 1509.68 txn/s, failed submission: 3.32 txn/s, expired: 3.32 txn/s, latency: 2159.06 ms, (p50: 1800 ms, p70: 2100, p90: 3600 ms, p99: 5500 ms), latency samples: 136060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1396.46 txn/s, submitted: 1399.33 txn/s, failed submission: 2.87 txn/s, expired: 2.87 txn/s, latency: 2132.06 ms, (p50: 1800 ms, p70: 2100, p90: 3600 ms, p99: 4800 ms), latency samples: 126680
5. check swarm health
Compatibility test for be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd passed
Upgrade the remaining nodes to version: 5ffa738c197007d5c6e348033d57c8379e22c7bd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1390.94 txn/s, submitted: 1395.27 txn/s, failed submission: 4.33 txn/s, expired: 4.33 txn/s, latency: 2320.70 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 4800 ms), latency samples: 122200
Test Ok

github-actions · 2024-11-19T21:36:05Z

✅ Forge suite `compat` success on `be3ccc58ef518259d63fab7f3e3613f2a6214268` ==> `5ffa738c197007d5c6e348033d57c8379e22c7bd`

Compatibility test results for be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd (PR)
1. Check liveness of validators at old version: be3ccc58ef518259d63fab7f3e3613f2a6214268
compatibility::simple-validator-upgrade::liveness-check : committed: 14670.71 txn/s, latency: 2288.21 ms, (p50: 1900 ms, p70: 2100, p90: 3300 ms, p99: 8100 ms), latency samples: 480480
2. Upgrading first Validator to new version: 5ffa738c197007d5c6e348033d57c8379e22c7bd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7309.62 txn/s, latency: 3782.04 ms, (p50: 4200 ms, p70: 4400, p90: 5100 ms, p99: 5300 ms), latency samples: 137520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7772.81 txn/s, latency: 4106.55 ms, (p50: 4200 ms, p70: 4300, p90: 6400 ms, p99: 6500 ms), latency samples: 256260
3. Upgrading rest of first batch to new version: 5ffa738c197007d5c6e348033d57c8379e22c7bd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7719.13 txn/s, latency: 3710.90 ms, (p50: 4100 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 143620
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7654.49 txn/s, latency: 4202.04 ms, (p50: 4500 ms, p70: 4600, p90: 5100 ms, p99: 5400 ms), latency samples: 252960
4. upgrading second batch to new version: 5ffa738c197007d5c6e348033d57c8379e22c7bd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11115.40 txn/s, latency: 2486.15 ms, (p50: 2800 ms, p70: 2900, p90: 3000 ms, p99: 3200 ms), latency samples: 192220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10000.97 txn/s, latency: 3175.47 ms, (p50: 2900 ms, p70: 3100, p90: 6000 ms, p99: 7200 ms), latency samples: 349120
5. check swarm health
Compatibility test for be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd passed
Test Ok

rahxephon89 changed the title ~~add flag~~ [WIP][trivial] add MOVE_LANGUAGE_V2=true to move_pr.sh Nov 18, 2024

rahxephon89 force-pushed the teng/add-v2-flag-to-move-pr-sh branch from 4924f31 to 1ea1d98 Compare November 19, 2024 00:04

rahxephon89 changed the title ~~[WIP][trivial] add MOVE_LANGUAGE_V2=true to move_pr.sh~~ [CI] add MOVE_LANGUAGE_V2=true to move_pr.sh Nov 19, 2024

rahxephon89 marked this pull request as ready for review November 19, 2024 01:28

rahxephon89 requested review from brmataptos, vineethk and fEst1ck November 19, 2024 01:29

rahxephon89 changed the title ~~[CI] add MOVE_LANGUAGE_V2=true to move_pr.sh~~ [CI][Compiler-v2] add MOVE_LANGUAGE_V2=true to move_pr.sh Nov 19, 2024

brmataptos approved these changes Nov 19, 2024

View reviewed changes

vineethk approved these changes Nov 19, 2024

View reviewed changes

rahxephon89 force-pushed the teng/add-v2-flag-to-move-pr-sh branch from 1ea1d98 to bab7467 Compare November 19, 2024 18:44

rahxephon89 requested a review from vineethk November 19, 2024 18:51

vineethk approved these changes Nov 19, 2024

View reviewed changes

rahxephon89 force-pushed the teng/add-v2-flag-to-move-pr-sh branch from bab7467 to ebca39a Compare November 19, 2024 19:01

add flag

5ffa738

rahxephon89 force-pushed the teng/add-v2-flag-to-move-pr-sh branch from ebca39a to 5ffa738 Compare November 19, 2024 20:03

rahxephon89 enabled auto-merge (squash) November 19, 2024 21:04

This comment has been minimized.

Sign in to view

rahxephon89 merged commit afd596e into main Nov 19, 2024
92 checks passed

rahxephon89 deleted the teng/add-v2-flag-to-move-pr-sh branch November 19, 2024 21:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI][Compiler-v2] add `MOVE_LANGUAGE_V2=true` to move_pr.sh #15309

[CI][Compiler-v2] add `MOVE_LANGUAGE_V2=true` to move_pr.sh #15309

rahxephon89 commented Nov 18, 2024 •

edited

Loading

trunk-io bot commented Nov 18, 2024 •

edited

Loading

rahxephon89 commented Nov 18, 2024

vineethk left a comment

vineethk Nov 19, 2024

rahxephon89 Nov 19, 2024

vineethk Nov 19, 2024

rahxephon89 Nov 19, 2024

vineethk Nov 19, 2024

rahxephon89 Nov 19, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

[CI][Compiler-v2] add MOVE_LANGUAGE_V2=true to move_pr.sh #15309

[CI][Compiler-v2] add MOVE_LANGUAGE_V2=true to move_pr.sh #15309

Conversation

rahxephon89 commented Nov 18, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Nov 18, 2024 • edited Loading

rahxephon89 commented Nov 18, 2024

vineethk left a comment

Choose a reason for hiding this comment

vineethk Nov 19, 2024

Choose a reason for hiding this comment

rahxephon89 Nov 19, 2024

Choose a reason for hiding this comment

vineethk Nov 19, 2024

Choose a reason for hiding this comment

rahxephon89 Nov 19, 2024

Choose a reason for hiding this comment

vineethk Nov 19, 2024

Choose a reason for hiding this comment

rahxephon89 Nov 19, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 19, 2024

✅ Forge suite realistic_env_max_load success on 5ffa738c197007d5c6e348033d57c8379e22c7bd

github-actions bot commented Nov 19, 2024

✅ Forge suite framework_upgrade success on be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd

github-actions bot commented Nov 19, 2024

✅ Forge suite compat success on be3ccc58ef518259d63fab7f3e3613f2a6214268 ==> 5ffa738c197007d5c6e348033d57c8379e22c7bd

[CI][Compiler-v2] add `MOVE_LANGUAGE_V2=true` to move_pr.sh #15309

[CI][Compiler-v2] add `MOVE_LANGUAGE_V2=true` to move_pr.sh #15309

rahxephon89 commented Nov 18, 2024 •

edited

Loading

trunk-io bot commented Nov 18, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `5ffa738c197007d5c6e348033d57c8379e22c7bd`

✅ Forge suite `framework_upgrade` success on `be3ccc58ef518259d63fab7f3e3613f2a6214268` ==> `5ffa738c197007d5c6e348033d57c8379e22c7bd`

✅ Forge suite `compat` success on `be3ccc58ef518259d63fab7f3e3613f2a6214268` ==> `5ffa738c197007d5c6e348033d57c8379e22c7bd`