Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler-v2] refactor resource index for ability checking of type parameters #15281

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Nov 14, 2024

Description

This PR rewrites the method call_to_borrow_global_for_index_op of handling resource index by using translate_call instead of constructing ExpData::Call explicitly so that the ability checking for type parameters can be correctly performed.

Close #15274

How Has This Been Tested?

  1. existing tests;
  2. add a new test case.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 14, 2024

⏱️ 1h 44m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 35m 🟥🟥🟩
rust-move-tests 12m 🟩
check-dynamic-deps 11m 🟩🟩🟩🟩🟩
rust-move-tests 9m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
rust-cargo-deny 5m 🟩🟩
rust-doc-tests 5m 🟩
check 4m 🟩
test-target-determinator 4m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
rust-move-tests 2m
fetch-last-released-docker-image-tag 2m 🟩
general-lints 1m 🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 5m 1m +208%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 marked this pull request as ready for review November 14, 2024 23:03
@rahxephon89 rahxephon89 changed the title [WIP][Compiler-v2] refactor resource index for ability checking of type parameters [Compiler-v2] refactor resource index for ability checking of type parameters Nov 14, 2024
@rahxephon89 rahxephon89 enabled auto-merge (squash) November 15, 2024 18:12
@rahxephon89 rahxephon89 enabled auto-merge (squash) November 15, 2024 18:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 03d9d6744129e910ebfa58535e7247cde04d5cf0

two traffics test: inner traffic : committed: 14395.69 txn/s, latency: 2763.72 ms, (p50: 2600 ms, p70: 2700, p90: 3000 ms, p99: 8700 ms), latency samples: 5473520
two traffics test : committed: 100.04 txn/s, latency: 1549.82 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 8200 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.049, avg: 1.434", "ConsensusProposalToOrdered: max: 0.314, avg: 0.292", "ConsensusOrderedToCommit: max: 0.378, avg: 0.367", "ConsensusProposalToCommit: max: 0.669, avg: 0.658"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.06s no progress at version 2392476 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.62s no progress at version 2392474 (avg 8.62s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0

Compatibility test results for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0 (PR)
Upgrade the nodes to version: 03d9d6744129e910ebfa58535e7247cde04d5cf0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1131.82 txn/s, submitted: 1134.97 txn/s, failed submission: 3.15 txn/s, expired: 3.15 txn/s, latency: 2873.96 ms, (p50: 2100 ms, p70: 2400, p90: 6500 ms, p99: 7900 ms), latency samples: 100680
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1092.03 txn/s, submitted: 1094.04 txn/s, failed submission: 2.01 txn/s, expired: 2.01 txn/s, latency: 2789.05 ms, (p50: 2100 ms, p70: 2800, p90: 6000 ms, p99: 8100 ms), latency samples: 97960
5. check swarm health
Compatibility test for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0 passed
Upgrade the remaining nodes to version: 03d9d6744129e910ebfa58535e7247cde04d5cf0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1176.33 txn/s, submitted: 1178.38 txn/s, failed submission: 2.05 txn/s, expired: 2.05 txn/s, latency: 2751.52 ms, (p50: 2100 ms, p70: 2700, p90: 5700 ms, p99: 7200 ms), latency samples: 103200
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0

Compatibility test results for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0 (PR)
1. Check liveness of validators at old version: 2bb2d43037a93d883729869d65c7c6c75b028fa1
compatibility::simple-validator-upgrade::liveness-check : committed: 16905.77 txn/s, latency: 2012.01 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 543180
2. Upgrading first Validator to new version: 03d9d6744129e910ebfa58535e7247cde04d5cf0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7281.14 txn/s, latency: 3607.69 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4600 ms), latency samples: 146540
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7683.88 txn/s, latency: 4129.54 ms, (p50: 4200 ms, p70: 4300, p90: 6500 ms, p99: 6900 ms), latency samples: 256740
3. Upgrading rest of first batch to new version: 03d9d6744129e910ebfa58535e7247cde04d5cf0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7265.86 txn/s, latency: 3820.12 ms, (p50: 4100 ms, p70: 4300, p90: 5100 ms, p99: 5300 ms), latency samples: 136580
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7706.38 txn/s, latency: 4148.10 ms, (p50: 4200 ms, p70: 4400, p90: 6400 ms, p99: 6700 ms), latency samples: 256420
4. upgrading second batch to new version: 03d9d6744129e910ebfa58535e7247cde04d5cf0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10983.26 txn/s, latency: 2465.62 ms, (p50: 2500 ms, p70: 2600, p90: 3900 ms, p99: 4300 ms), latency samples: 213120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11123.84 txn/s, latency: 2792.73 ms, (p50: 2500 ms, p70: 2600, p90: 5200 ms, p99: 6900 ms), latency samples: 359020
5. check swarm health
Compatibility test for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 03d9d6744129e910ebfa58535e7247cde04d5cf0 passed
Test Ok

@rahxephon89 rahxephon89 merged commit b309830 into main Nov 15, 2024
57 of 60 checks passed
@rahxephon89 rahxephon89 deleted the teng/fix-15274 branch November 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Compiler-v2] index notation does not check ability properly
3 participants