-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network] Add simple queuing metrics for message sends. #15268
Draft
JoshLind
wants to merge
4
commits into
main
Choose a base branch
from
net_queue_lat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+801
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 3h 57m total CI duration on this PR
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
from
November 14, 2024 02:16
658566d
to
a9167e5
Compare
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
2 times, most recently
from
November 14, 2024 03:26
3910c19
to
8522b5a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
2 times, most recently
from
November 14, 2024 18:11
18ffd3d
to
669a73e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
from
November 14, 2024 21:52
669a73e
to
7db151a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
2 times, most recently
from
November 15, 2024 01:50
e1e55b2
to
8589444
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
from
November 15, 2024 04:23
8589444
to
d586e08
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
2 times, most recently
from
November 15, 2024 14:18
5adeeff
to
9af9761
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
from
November 15, 2024 15:41
9af9761
to
cd1e196
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
net_queue_lat
branch
from
November 16, 2024 02:20
cd1e196
to
8a39b44
Compare
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds simple queuing metrics for message sends to the network stack. Specifically, we now track the time between when a message is sent by an application (after serialization), until when it is finally written to the network wire.
The next set of PRs will include: (i) receiver side metrics; and (ii) support for messages with embedded timestamps for tracking transport times.
Testing Plan
Existing test infrastructure and manual verification, e.g., I hacked the code to force messages to be streamed. You can see the new metrics in the
Network Queue Latencies
section of the dashboard.