Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Release 4.5.0 #15267

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[cli] Release 4.5.0 #15267

merged 1 commit into from
Nov 15, 2024

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Nov 13, 2024

Description

Release 4.5.0 to support AIP-80

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 13, 2024

⏱️ 1h 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 10m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+1 more)
test-target-determinator 7m 🟩
check 7m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
rust-move-tests 3m
rust-doc-tests 3m
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 3m 🟩🟩🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 16m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

crates/aptos/CHANGELOG.md Outdated Show resolved Hide resolved
crates/aptos/CHANGELOG.md Outdated Show resolved Hide resolved
@gregnazario gregnazario enabled auto-merge (squash) November 15, 2024 17:36

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5454900d5aee6a6f44087c982960d7028c60809c

two traffics test: inner traffic : committed: 14556.12 txn/s, latency: 2732.06 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5534580
two traffics test : committed: 100.04 txn/s, latency: 1458.82 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 8300 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.015, avg: 1.548", "ConsensusProposalToOrdered: max: 0.315, avg: 0.290", "ConsensusOrderedToCommit: max: 0.374, avg: 0.364", "ConsensusProposalToCommit: max: 0.662, avg: 0.654"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.23s no progress at version 1887211 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.58s no progress at version 1887209 (avg 8.40s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c

Compatibility test results for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c (PR)
Upgrade the nodes to version: 5454900d5aee6a6f44087c982960d7028c60809c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1406.44 txn/s, submitted: 1409.57 txn/s, failed submission: 3.12 txn/s, expired: 3.12 txn/s, latency: 2182.19 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 5800 ms), latency samples: 126060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1382.13 txn/s, submitted: 1384.69 txn/s, failed submission: 2.56 txn/s, expired: 2.56 txn/s, latency: 2424.26 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 5200 ms), latency samples: 118720
5. check swarm health
Compatibility test for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c passed
Upgrade the remaining nodes to version: 5454900d5aee6a6f44087c982960d7028c60809c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1300.89 txn/s, submitted: 1303.13 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2355.63 ms, (p50: 2100 ms, p70: 2400, p90: 3800 ms, p99: 6100 ms), latency samples: 115900
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c

Compatibility test results for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c (PR)
1. Check liveness of validators at old version: 2bb2d43037a93d883729869d65c7c6c75b028fa1
compatibility::simple-validator-upgrade::liveness-check : committed: 14663.34 txn/s, latency: 2092.46 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 7500 ms), latency samples: 552180
2. Upgrading first Validator to new version: 5454900d5aee6a6f44087c982960d7028c60809c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7187.58 txn/s, latency: 3939.79 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 4900 ms), latency samples: 132420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6807.23 txn/s, latency: 4714.22 ms, (p50: 4700 ms, p70: 4900, p90: 6600 ms, p99: 6800 ms), latency samples: 226180
3. Upgrading rest of first batch to new version: 5454900d5aee6a6f44087c982960d7028c60809c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7600.74 txn/s, latency: 3663.06 ms, (p50: 3700 ms, p70: 4400, p90: 4700 ms, p99: 5000 ms), latency samples: 141240
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7554.29 txn/s, latency: 4259.77 ms, (p50: 4400 ms, p70: 4500, p90: 6300 ms, p99: 6400 ms), latency samples: 254360
4. upgrading second batch to new version: 5454900d5aee6a6f44087c982960d7028c60809c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12010.06 txn/s, latency: 2319.82 ms, (p50: 2500 ms, p70: 2600, p90: 2900 ms, p99: 3100 ms), latency samples: 208160
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10574.14 txn/s, latency: 2982.49 ms, (p50: 2700 ms, p70: 2900, p90: 5700 ms, p99: 7300 ms), latency samples: 369580
5. check swarm health
Compatibility test for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> 5454900d5aee6a6f44087c982960d7028c60809c passed
Test Ok

@gregnazario gregnazario merged commit 8527dbe into aptos-labs:main Nov 15, 2024
82 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants