Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp][aptos-release-v1.23] [rosetta] Fix staking balances #15262

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[cp][aptos-release-v1.23] [rosetta] Fix staking balances #15262

merged 2 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport

This will backport the following commits from main to aptos-release-v1.23:

Questions ?

Please refer to the Backport tool documentation

@gregnazario
[rosetta] Fix staking balances (#15247)
77ca03b 
the last refactor made it get staking balances and the account's balance

this should fix it so it never cross contaminates between staking, delegated
staking, and normal balances.  It's much more straightforward and should be
easier to understand.

(cherry picked from commit 7d6d59c)
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 13, 2024 •
edited
Loading

⏱️ 1h 54m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 50m 🟩 🟩 
rust-unit-tests 24m 🟩 
rust-move-tests 9m 🟩 
execution-performance / test-target-determinator 8m 🟩 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 4m 🟩 
check 4m ⬜ 🟩 
check-dynamic-deps 3m 🟩 🟩 
rust-cargo-deny 2m 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
semgrep/ci 52s 🟩 🟩 
general-lints 31s 🟩 
permission-check 14s 🟩 🟩 
file_change_determinator 14s ⬜ 🟩 
permission-check 11s ⬜ 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 27m 17m +64%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
22 tasks
@gregnazario gregnazario enabled auto-merge (squash) November 13, 2024 23:49
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite realistic_env_max_load success on e95130dd1d27f595570e881c191e0a29e51e092a

two traffics test: inner traffic : committed: 14196.63 txn/s, latency: 2803.16 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 5300 ms), latency samples: 5398120
two traffics test : committed: 99.99 txn/s, latency: 1511.22 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 5900 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.187, avg: 1.624", "ConsensusProposalToOrdered: max: 0.332, avg: 0.295", "ConsensusOrderedToCommit: max: 0.372, avg: 0.351", "ConsensusProposalToCommit: max: 0.670, avg: 0.646"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.96s no progress at version 2480750 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.34s no progress at version 2480005 (avg 8.34s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a (PR)
Upgrade the nodes to version: e95130dd1d27f595570e881c191e0a29e51e092a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1221.68 txn/s, submitted: 1224.37 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2504.04 ms, (p50: 2400 ms, p70: 2400, p90: 3600 ms, p99: 5000 ms), latency samples: 108940
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1442.02 txn/s, submitted: 1445.00 txn/s, failed submission: 2.97 txn/s, expired: 2.97 txn/s, latency: 2133.02 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 5400 ms), latency samples: 126040
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a passed
Upgrade the remaining nodes to version: e95130dd1d27f595570e881c191e0a29e51e092a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1514.33 txn/s, submitted: 1516.15 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2354.74 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5400 ms), latency samples: 116380
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 13622.52 txn/s, latency: 2506.47 ms, (p50: 2200 ms, p70: 2300, p90: 2500 ms, p99: 7800 ms), latency samples: 475160
2. Upgrading first Validator to new version: e95130dd1d27f595570e881c191e0a29e51e092a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6753.96 txn/s, latency: 4180.51 ms, (p50: 4700 ms, p70: 5000, p90: 5200 ms, p99: 5300 ms), latency samples: 122420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6799.60 txn/s, latency: 4741.82 ms, (p50: 5000 ms, p70: 5200, p90: 6400 ms, p99: 6800 ms), latency samples: 226100
3. Upgrading rest of first batch to new version: e95130dd1d27f595570e881c191e0a29e51e092a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7161.00 txn/s, latency: 3877.08 ms, (p50: 4200 ms, p70: 4700, p90: 5300 ms, p99: 5600 ms), latency samples: 131300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7198.27 txn/s, latency: 4471.19 ms, (p50: 4700 ms, p70: 4800, p90: 6200 ms, p99: 6600 ms), latency samples: 240720
4. upgrading second batch to new version: e95130dd1d27f595570e881c191e0a29e51e092a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11578.36 txn/s, latency: 2413.34 ms, (p50: 2200 ms, p70: 2400, p90: 3200 ms, p99: 4000 ms), latency samples: 197340
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11316.75 txn/s, latency: 2726.71 ms, (p50: 2200 ms, p70: 2600, p90: 5500 ms, p99: 7700 ms), latency samples: 370760
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> e95130dd1d27f595570e881c191e0a29e51e092a passed
Test Ok

@gregnazario gregnazario merged commit a0ec6ba into aptos-release-v1.23 Nov 14, 2024
47 of 48 checks passed
@gregnazario gregnazario deleted the backport/aptos-release-v1.23/pr-15247 branch November 14, 2024 00:21
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 14, 2024

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos approved these changes

@gregnazario gregnazario gregnazario approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@lightmark lightmark Awaiting requested review from lightmark

Assignees

@thepomeranian thepomeranian

Labels
cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregnazario @igor-aptos @thepomeranian