Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmarks] Module loading benches (simple) #15255

Closed
wants to merge 25 commits into from
Closed

[benchmarks] Module loading benches (simple) #15255

wants to merge 25 commits into from

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 12, 2024 •
edited
Loading

⏱️ 2h 9m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 20m 🟩 🟩 🟩 🟩 🟩 (+6 more)
check-dynamic-deps 18m 🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-move-tests 10m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m 🟥 
rust-move-tests 9m ⬜ 
general-lints 6m 🟩 🟩 🟩 🟩 🟩 (+6 more)
semgrep/ci 5m 🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-move-tests 4m 🟥 
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check 39s 🟩 🟩 🟩 🟩 🟩 (+6 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +187%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

This was referenced Nov 12, 2024
Merged
Closed
Closed
Closed
@georgemitenkov Graphite App
Copy link
Contributor Author

georgemitenkov commented Nov 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov mentioned this pull request Nov 12, 2024
Merged
22 tasks
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch from b14d5f5 to e425538 Compare November 12, 2024 16:07
@georgemitenkov georgemitenkov mentioned this pull request Nov 12, 2024
Merged
22 tasks
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch 2 times, most recently from 642ae8f to 6723c0a Compare November 12, 2024 21:57
@georgemitenkov
[refactoring] Move explicit sync wrapper to aptos-types
97188b4
@georgemitenkov
[refactoring] Move & rename immutabke module cache to aptos-types
d958da3
@georgemitenkov
[global cache] Draft e2e implementation
9f0f976
@georgemitenkov
[testing] Added different test cases for global caches
32ebdd3
@georgemitenkov
[perf] Framework prefetch
2a65957
@georgemitenkov
[exp] Avoid repeated arcswap load
0fda569
@georgemitenkov
[cleanup] Add errors, documentation, reset state on panics
60ceafb
@georgemitenkov
[refactoring] Remove versions from module code
583ccfa
@georgemitenkov
[comments] Addressing Rati's comments + adding size in bytes to modul…
8bee4e8 
…e cache
@georgemitenkov
[draft] Better states and encapsulation
6c40603
@georgemitenkov
prior to addressing comments:
7c2dbf7 
  - Fixed a bug where on successful marking as executing we were re-creating environment
  - Removed optional manager in BlockAptosVM, instead a new instance can be provided
  - Removed clean state, instead manager is initialized to Done(None) and optional values
    need to be provided.
@georgemitenkov
[comments] Address Rati's and Zekun's comments
03a1ea2
@georgemitenkov
[fix] Add done --> ready transition for unit tests
28116bc
@georgemitenkov
Move ready checks to cache manager, better encapsulation by passing h…
d45df1f 
…ash values throughout
@georgemitenkov
[cleanup] Set execute_no_limit to always use Nones for block IDs
f317dcf
@georgemitenkov
Feature gating
03bb4df
@georgemitenkov
[comments] Addressing Igor's comments
715f3a9
@georgemitenkov georgemitenkov force-pushed the george/parent-block-checks branch from f190968 to 715f3a9 Compare November 13, 2024 00:37
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch from 6723c0a to 62d4754 Compare November 13, 2024 00:37
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch from 62d4754 to 5e01333 Compare November 13, 2024 00:53
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch from 5e01333 to 5ee7314 Compare November 13, 2024 01:03
@georgemitenkov georgemitenkov force-pushed the george/module-benhcmarks branch from 5ee7314 to 9fad83d Compare November 13, 2024 10:41
@georgemitenkov georgemitenkov force-pushed the george/parent-block-checks branch 5 times, most recently from 1a54836 to 4f1b9f9 Compare November 13, 2024 22:54
Base automatically changed from george/parent-block-checks to main November 13, 2024 23:29
@georgemitenkov georgemitenkov deleted the george/module-benhcmarks branch November 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@gelash gelash Awaiting requested review from gelash gelash will be requested when the pull request is marked ready for review gelash is a code owner

@runtian-zhou runtian-zhou Awaiting requested review from runtian-zhou runtian-zhou will be requested when the pull request is marked ready for review runtian-zhou is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl danielxiangzl will be requested when the pull request is marked ready for review danielxiangzl is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@georgemitenkov