Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer] add new txns for user transactions test #15242

Merged

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Nov 8, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 8, 2024

⏱️ 43m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 9m 🟩
execution-performance / test-target-determinator 6m 🟩
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
rust-cargo-deny 4m 🟩🟩
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
check-dynamic-deps 2m 🟩🟩
fetch-last-released-docker-image-tag 1m 🟩
general-lints 1m 🟩🟩
semgrep/ci 44s 🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 20s 🟩
permission-check 12s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 6m 4m +34%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

yuunlimm commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yuunlimm and the rest of your teammates on Graphite Graphite

@yuunlimm yuunlimm marked this pull request as ready for review November 8, 2024 20:03
@dermanyang dermanyang enabled auto-merge (squash) November 13, 2024 19:03

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on cf85a5d78c6b6da6499201f583f5fef6a434071e

two traffics test: inner traffic : committed: 14443.09 txn/s, latency: 2754.42 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5491560
two traffics test : committed: 99.95 txn/s, latency: 1565.52 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 10900 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.980, avg: 1.578", "ConsensusProposalToOrdered: max: 0.326, avg: 0.293", "ConsensusOrderedToCommit: max: 0.364, avg: 0.350", "ConsensusProposalToCommit: max: 0.657, avg: 0.644"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.79s no progress at version 2901448 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.62s no progress at version 2901446 (avg 8.62s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 8a161886956d0b8360b152f051628bed624f7c24 ==> cf85a5d78c6b6da6499201f583f5fef6a434071e

Compatibility test results for 8a161886956d0b8360b152f051628bed624f7c24 ==> cf85a5d78c6b6da6499201f583f5fef6a434071e (PR)
1. Check liveness of validators at old version: 8a161886956d0b8360b152f051628bed624f7c24
compatibility::simple-validator-upgrade::liveness-check : committed: 14828.65 txn/s, latency: 2071.36 ms, (p50: 1600 ms, p70: 1800, p90: 2100 ms, p99: 18400 ms), latency samples: 579300
2. Upgrading first Validator to new version: cf85a5d78c6b6da6499201f583f5fef6a434071e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8131.54 txn/s, latency: 3557.91 ms, (p50: 4000 ms, p70: 4100, p90: 4200 ms, p99: 4200 ms), latency samples: 150560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7174.11 txn/s, latency: 4286.79 ms, (p50: 4300 ms, p70: 4300, p90: 6100 ms, p99: 6900 ms), latency samples: 271020
3. Upgrading rest of first batch to new version: cf85a5d78c6b6da6499201f583f5fef6a434071e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7848.50 txn/s, latency: 3668.48 ms, (p50: 4100 ms, p70: 4200, p90: 4300 ms, p99: 4500 ms), latency samples: 146060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6973.11 txn/s, latency: 4232.39 ms, (p50: 4400 ms, p70: 4500, p90: 4500 ms, p99: 6000 ms), latency samples: 263660
4. upgrading second batch to new version: cf85a5d78c6b6da6499201f583f5fef6a434071e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11673.79 txn/s, latency: 2355.33 ms, (p50: 2400 ms, p70: 2700, p90: 3100 ms, p99: 3500 ms), latency samples: 201420
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10360.29 txn/s, latency: 3000.63 ms, (p50: 2700 ms, p70: 2900, p90: 5700 ms, p99: 7500 ms), latency samples: 336340
5. check swarm health
Compatibility test for 8a161886956d0b8360b152f051628bed624f7c24 ==> cf85a5d78c6b6da6499201f583f5fef6a434071e passed
Test Ok

@dermanyang dermanyang merged commit 607f985 into main Nov 13, 2024
95 checks passed
@dermanyang dermanyang deleted the 11-08-_indexer_add_new_txns_for_user_transactions_test branch November 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants