Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exebench for keyless #15233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

exebench for keyless #15233

wants to merge 2 commits into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Nov 7, 2024

Description

  • Add new genesis parameter initial_jwks.
  • Add new genesis parameter keyless_groth16_vk_override.
  • Add new executor benchmark parameter --use-keyless-accounts.
  • If executor benchmark is used in keyless mode, run genesis with groth16 keys from simulation.

Bench example.

/// step 1, create DB
cargo run -p aptos-executor-benchmark -- \
  --enable-storage-sharding \
  --block-executor-type aptos-vm-with-block-stm \
  --use-keyless-accounts \ #NEW!
  create-db --data-dir /tmp/db2 --num-accounts 100

/// step 2, actual bench
cargo run -p aptos-executor-benchmark -- \
  --block-size 100 \
  --enable-storage-sharding \
  --block-executor-type aptos-vm-with-block-stm \
  --use-keyless-accounts \ #NEW!
  run-executor --main-signer-accounts 100 --data-dir /tmp/db2 --checkpoint-dir /tmp/ck2 --blocks 99

The actual TPS benchmarking and threshold setting will be a separate PR.

How Has This Been Tested?

Executor-benchmark local runs.

Key Areas to Review

Does hash_public_inputs refactoring change execution result?

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

n/a

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 7, 2024

⏱️ 1h 21m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 14m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 10m 🟥
rust-move-tests 9m 🟥
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
general-lints 4m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 3m 🟥
rust-move-tests 2m
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+5 more)
rust-move-tests 1m
rust-move-tests 1m
rust-move-tests 59s
permission-check 49s 🟩🟩🟩🟩🟩 (+9 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma force-pushed the zjma/exebench-for-keyless branch 2 times, most recently from 45aa2fd to dcddf16 Compare November 8, 2024 21:38
@zjma zjma marked this pull request as ready for review November 8, 2024 21:51
sdk/src/types.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mstraka100 mstraka100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Looks good overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants