Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequence numbers for local account pool in transaction generator #15229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vusirikala
Copy link
Contributor

Description

This PR adds a new function called update_sequence_numbers in the transaction generator.

The transaction emitter maintains a pool of accounts and uses these accounts to send transactions to the blockchain. The transaction emitter keeps track of the committed and expired transactions. The transaction emitter also fetches the latest sequence numbers for this pool of accounts and updates their local sequence numbers accordingly.

But for some workflow-based transaction types, the transaction generator maintains its own local pool of accounts, and doesn't use the account pool in transaction emitter for creating transactions. This means, when some transaction fails to execute, the transaction emitter doesn't have a way to update the sequence number for this account pool.

This PR adds the update_sequence_numbers function in the transaction generator. The transaction emitter can use this function to call the transaction generator with the latest fetched sequence numbers. Currently, this function implementation is left empty.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 7, 2024

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 9m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 35s 🟩
general-lints 27s 🟩
semgrep/ci 22s 🟩
file_change_determinator 13s 🟩
permission-check 4s 🟩
permission-check 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@vusirikala vusirikala requested review from igor-aptos and sitalkedia and removed request for igor-aptos November 7, 2024 18:50
Copy link
Contributor

@sitalkedia sitalkedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants