Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] use zstd compression and upgrade action #15228

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Nov 7, 2024

Description

Apparently, according to this blog, using zstd compression can provide better compression/decompression times for docker image, speeding up both image build times and container start times.

Also, upgrades the docker setup action to use latest version of docker.

Copy link

trunk-io bot commented Nov 7, 2024

⏱️ 4h 35m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-images / rust-all 2h 29m
test-target-determinator 42m 🟩🟩🟩 (+6 more)
rust-cargo-deny 18m 🟩🟩🟩🟩 (+6 more)
check-dynamic-deps 17m 🟩🟩🟩🟩🟩 (+7 more)
general-lints 5m 🟩🟩🟩🟩 (+6 more)
semgrep/ci 5m 🟩🟩🟩🟩🟩 (+7 more)
execution-performance / test-target-determinator 5m 🟩
rust-doc-tests 5m 🟩
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+7 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+6 more)
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Nov 7, 2024

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun marked this pull request as ready for review November 7, 2024 23:33
@ibalajiarun ibalajiarun requested review from a team as code owners November 7, 2024 23:33
@ibalajiarun ibalajiarun requested a review from a team November 7, 2024 23:33
@ibalajiarun ibalajiarun changed the title [docker] use zstd compression [docker] use zstd compression and upgrade action Nov 7, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ Forge suite realistic_env_max_load success on 5ad7deddf7b6f0fda46b905effc352da4b432299

two traffics test: inner traffic : committed: 14259.43 txn/s, latency: 2785.38 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5421800
two traffics test : committed: 100.09 txn/s, latency: 1543.70 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 9200 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.970, avg: 1.590", "ConsensusProposalToOrdered: max: 0.321, avg: 0.294", "ConsensusOrderedToCommit: max: 0.369, avg: 0.360", "ConsensusProposalToCommit: max: 0.661, avg: 0.655"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 2595666 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.53s no progress at version 2595664 (avg 8.53s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ Forge suite framework_upgrade success on fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299

Compatibility test results for fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299 (PR)
Upgrade the nodes to version: 5ad7deddf7b6f0fda46b905effc352da4b432299
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1218.59 txn/s, submitted: 1220.60 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2674.98 ms, (p50: 2100 ms, p70: 2700, p90: 5400 ms, p99: 6900 ms), latency samples: 108820
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1239.27 txn/s, submitted: 1240.71 txn/s, failed submission: 1.44 txn/s, expired: 1.44 txn/s, latency: 2614.18 ms, (p50: 1800 ms, p70: 2400, p90: 5400 ms, p99: 8000 ms), latency samples: 103140
5. check swarm health
Compatibility test for fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299 passed
Upgrade the remaining nodes to version: 5ad7deddf7b6f0fda46b905effc352da4b432299
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1363.80 txn/s, submitted: 1366.66 txn/s, failed submission: 2.86 txn/s, expired: 2.86 txn/s, latency: 2285.15 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4800 ms), latency samples: 123920
Test Ok

Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ Forge suite compat success on fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299

Compatibility test results for fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299 (PR)
1. Check liveness of validators at old version: fcd2dedf6ca61a23f4979e944c629dcdbdae5dca
compatibility::simple-validator-upgrade::liveness-check : committed: 15116.53 txn/s, latency: 1917.37 ms, (p50: 1800 ms, p70: 1900, p90: 2200 ms, p99: 4500 ms), latency samples: 579860
2. Upgrading first Validator to new version: 5ad7deddf7b6f0fda46b905effc352da4b432299
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4985.52 txn/s, latency: 5854.17 ms, (p50: 6600 ms, p70: 6900, p90: 7000 ms, p99: 7200 ms), latency samples: 102040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4938.69 txn/s, latency: 6736.35 ms, (p50: 7300 ms, p70: 7600, p90: 7800 ms, p99: 7900 ms), latency samples: 175700
3. Upgrading rest of first batch to new version: 5ad7deddf7b6f0fda46b905effc352da4b432299
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5477.58 txn/s, latency: 5225.43 ms, (p50: 6000 ms, p70: 6300, p90: 6400 ms, p99: 6800 ms), latency samples: 104460
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5278.04 txn/s, latency: 5906.44 ms, (p50: 6400 ms, p70: 6400, p90: 6600 ms, p99: 7800 ms), latency samples: 196120
4. upgrading second batch to new version: 5ad7deddf7b6f0fda46b905effc352da4b432299
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8408.10 txn/s, latency: 3390.99 ms, (p50: 3700 ms, p70: 3800, p90: 4600 ms, p99: 4800 ms), latency samples: 155720
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9850.70 txn/s, latency: 3264.35 ms, (p50: 3400 ms, p70: 3500, p90: 3700 ms, p99: 4100 ms), latency samples: 322360
5. check swarm health
Compatibility test for fcd2dedf6ca61a23f4979e944c629dcdbdae5dca ==> 5ad7deddf7b6f0fda46b905effc352da4b432299 passed
Test Ok

Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ibalajiarun ibalajiarun merged commit a9b7e7b into main Nov 15, 2024
76 of 92 checks passed
@ibalajiarun ibalajiarun deleted the balaji/docker-compression branch November 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants