-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --host-postgres-host flag to CLI for localnet #15216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 51m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
banool
force-pushed
the
banool/host-postgres-host
branch
from
November 6, 2024 19:45
fd7a1a3
to
0cea0fd
Compare
GhostWalker562
approved these changes
Nov 6, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
gregnazario
approved these changes
Nov 6, 2024
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
--use-host-postgres
, it can sometimes be helpful to specify a different address for the postgres instance rather than127.0.0.1
. This PR adds the--host-postgres-host
flag to let you do that.How Has This Been Tested?
I confirmed that if you use a host where a DB is running the localnet comes up, and otherwise does not.
Key Areas to Review
N/A
Type of Change
Which Components or Systems Does This Change Impact?
Checklist