Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --host-postgres-host flag to CLI for localnet #15216

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

banool
Copy link
Contributor

@banool banool commented Nov 6, 2024

Description

When using --use-host-postgres, it can sometimes be helpful to specify a different address for the postgres instance rather than 127.0.0.1. This PR adds the --host-postgres-host flag to let you do that.

How Has This Been Tested?

cargo run -p aptos -- node run-localnet --use-host-postgres --host-postgres-host 1.2.3.4 --with-indexer-api

I confirmed that if you use a host where a DB is running the localnet comes up, and otherwise does not.

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 6, 2024

⏱️ 51m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 6m 🟩
check 6m 🟩
rust-cargo-deny 5m 🟩🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
rust-doc-tests 2m
rust-move-tests 2m
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 32s 🟩🟩🟩
file_change_determinator 23s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +125%
execution-performance / single-node-performance 10s 15m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool enabled auto-merge (squash) November 6, 2024 19:43

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite realistic_env_max_load success on 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c

two traffics test: inner traffic : committed: 14318.54 txn/s, latency: 2776.18 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5444220
two traffics test : committed: 99.90 txn/s, latency: 1588.55 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 8500 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.053, avg: 1.605", "ConsensusProposalToOrdered: max: 0.329, avg: 0.296", "ConsensusOrderedToCommit: max: 0.376, avg: 0.363", "ConsensusProposalToCommit: max: 0.668, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.06s no progress at version 1911620 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.28s no progress at version 1911618 (avg 7.92s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite framework_upgrade success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c (PR)
Upgrade the nodes to version: 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1363.48 txn/s, submitted: 1365.54 txn/s, failed submission: 2.06 txn/s, expired: 2.06 txn/s, latency: 2465.24 ms, (p50: 2100 ms, p70: 2400, p90: 4500 ms, p99: 6000 ms), latency samples: 118860
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1089.18 txn/s, submitted: 1091.57 txn/s, failed submission: 2.40 txn/s, expired: 2.40 txn/s, latency: 2659.45 ms, (p50: 2100 ms, p70: 2600, p90: 5700 ms, p99: 7200 ms), latency samples: 99980
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c passed
Upgrade the remaining nodes to version: 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1398.89 txn/s, submitted: 1400.85 txn/s, failed submission: 1.96 txn/s, expired: 1.96 txn/s, latency: 2344.85 ms, (p50: 2100 ms, p70: 2400, p90: 3700 ms, p99: 5800 ms), latency samples: 114180
Test Ok

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 15203.24 txn/s, latency: 2150.58 ms, (p50: 2000 ms, p70: 2200, p90: 2800 ms, p99: 4200 ms), latency samples: 496600
2. Upgrading first Validator to new version: 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6807.07 txn/s, latency: 4203.38 ms, (p50: 4800 ms, p70: 5000, p90: 5100 ms, p99: 5300 ms), latency samples: 128460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6200.72 txn/s, latency: 5055.39 ms, (p50: 5100 ms, p70: 5200, p90: 7100 ms, p99: 7300 ms), latency samples: 238500
3. Upgrading rest of first batch to new version: 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5211.02 txn/s, latency: 5579.81 ms, (p50: 6300 ms, p70: 6500, p90: 6800 ms, p99: 7100 ms), latency samples: 101740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5422.65 txn/s, latency: 6019.18 ms, (p50: 6400 ms, p70: 6800, p90: 7200 ms, p99: 7700 ms), latency samples: 184240
4. upgrading second batch to new version: 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8718.61 txn/s, latency: 3278.95 ms, (p50: 3500 ms, p70: 4000, p90: 4500 ms, p99: 4700 ms), latency samples: 165120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8480.10 txn/s, latency: 3735.15 ms, (p50: 3500 ms, p70: 4100, p90: 5800 ms, p99: 6900 ms), latency samples: 277620
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 0cea0fdfa9ae1409180db6d5dc006ea0f024bc7c passed
Test Ok

@banool banool merged commit ecc6ce9 into main Nov 6, 2024
47 of 48 checks passed
@banool banool deleted the banool/host-postgres-host branch November 6, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants