Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replay] Add transactions to skip for V2 loader #15207

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[replay] Add transactions to skip for V2 loader #15207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f7d959
[replay] Add tns to skip
georgemitenkov Nov 6, 2024
15bcea3
[replay] Add txns to skip flag
georgemitenkov Nov 6, 2024
e0dc552
Fix wrong ranges & update with new txns
georgemitenkov Nov 7, 2024
56187b6
rollback loader v2 force enable
georgemitenkov Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/replay-verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
SUB_DIR: e1
HISTORY_START: 862000000
# to see historical TXNS_TO_SKIP, check out ce6158ac2764ee9d4c8738a85f3bcdc6bd0cadc1
TXNS_TO_SKIP: "0"
TXNS_TO_SKIP: 1232167272 1232167433 1235493554 1239820988 1250224262 1255724440 1354496836 1354498540 1354518687 1354538946 1354547451 1354547636 1354558872 1877277141 5431332424 5519863118 5519863551 5519864968 5519871391 5519874963 5519932878 5519937773 5519943799 5519946298 5519946983 5519948038 5521992576 5523758958 5525311310 5525344101 5526949497 5527564033 5609106498 5611465782 5611472644 5938100116 5938192908 5938204128 5938221027 6047311953 6204828501 6206344839
# 1195000000-122000000: https://github.com/aptos-labs/aptos-core/pull/13832
RANGES_TO_SKIP: "1195000000-1220000000"
BACKUP_CONFIG_TEMPLATE_PATH: terraform/helm/fullnode/files/backup/gcs.yaml
Expand All @@ -90,7 +90,7 @@ jobs:
SUB_DIR: e1
HISTORY_START: 518000000
#TXNS_TO_SKIP: 12253479 12277499 148358668
TXNS_TO_SKIP: "0"
TXNS_TO_SKIP: 523296049 523298111 575378008 575383660 575455170 575457845 575461986 575470789 596888095 612286393 981890562 1011802725 1030023658 1652667187 1652669110 1652686860 1652689144 1652722847 1654190659 1654191460 1673664597 1730942524 1730944006 1730945331 1730945814 1730946863 1730952284 1730956071 1730959853 1730967212 1731006027 1759904543 1792070645 1797308520 1798657294 1806178096
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherry-x are we fine with skipping transactions on mainnet?

@georgemitenkov how recent are these transactions? If leader v2 is onchain flag - what do these represent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this range, the first skip is 27.03.24 and the last is basically now: 17.10.24. The reason why we want to skip is that we can completely remove old V1 code then, and the trade off few dozen of transactions that publish code seems good.

See the spreadsheet for actual divergences, those are only due to bugs in old loader (went to through them one by one). For instance, we were flushing module cache and losing error messages, there are a number of cases where the difference is None vs Some(msg) in VMStatus. There are also 2 other cases: 1) init_module not linking correctly before, 2) not topologically sorted bundles not linking correctly and failing to publish.

Ideally, I would not skip but specify the difference in write set, but we cannot do it with the current replay, hence skipping and documenting in a spreadsheet what is the diff.

# 1197378568-1198492648: https://github.com/aptos-labs/aptos-core/pull/13832
RANGES_TO_SKIP: "1197378568-1198492648"
BACKUP_CONFIG_TEMPLATE_PATH: terraform/helm/fullnode/files/backup/gcs.yaml
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/workflow-run-replay-verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ jobs:
./aptos-debugger aptos-db replay-verify \
--metadata-cache-dir $MC \
--command-adapter-config ${{ inputs.BACKUP_CONFIG_TEMPLATE_PATH }} \
--txns-to-skip ${{ inputs.TXNS_TO_SKIP }} \
--start-version $begin \
--end-version $end \
\
Expand Down
Loading